Re: [PATCH v2] writeback: use exact memcg dirty counts

2019-04-02 Thread Andrew Morton
On Mon, 1 Apr 2019 14:20:44 -0400 Johannes Weiner wrote: > On Fri, Mar 29, 2019 at 10:46:09AM -0700, Greg Thelen wrote: > > @@ -3907,10 +3923,10 @@ void mem_cgroup_wb_stats(struct bdi_writeback *wb, > > unsigned long *pfilepages, > > struct mem_cgroup *memcg =

Re: [PATCH v2] writeback: use exact memcg dirty counts

2019-04-01 Thread Johannes Weiner
On Fri, Mar 29, 2019 at 10:46:09AM -0700, Greg Thelen wrote: > @@ -3907,10 +3923,10 @@ void mem_cgroup_wb_stats(struct bdi_writeback *wb, > unsigned long *pfilepages, > struct mem_cgroup *memcg = mem_cgroup_from_css(wb->memcg_css); > struct mem_cgroup *parent; > > - *pdirty =

Re: [PATCH v2] writeback: use exact memcg dirty counts

2019-04-01 Thread Johannes Weiner
On Fri, Mar 29, 2019 at 10:46:09AM -0700, Greg Thelen wrote: > Since commit a983b5ebee57 ("mm: memcontrol: fix excessive complexity in > memory.stat reporting") memcg dirty and writeback counters are managed > as: > 1) per-memcg per-cpu values in range of [-32..32] > 2) per-memcg atomic counter >

Re: [PATCH v2] writeback: use exact memcg dirty counts

2019-03-29 Thread Roman Gushchin
On Fri, Mar 29, 2019 at 10:46:09AM -0700, Greg Thelen wrote: > Since commit a983b5ebee57 ("mm: memcontrol: fix excessive complexity in > memory.stat reporting") memcg dirty and writeback counters are managed > as: > 1) per-memcg per-cpu values in range of [-32..32] > 2) per-memcg atomic counter >

[PATCH v2] writeback: use exact memcg dirty counts

2019-03-29 Thread Greg Thelen
Since commit a983b5ebee57 ("mm: memcontrol: fix excessive complexity in memory.stat reporting") memcg dirty and writeback counters are managed as: 1) per-memcg per-cpu values in range of [-32..32] 2) per-memcg atomic counter When a per-cpu counter cannot fit in [-32..32] it's flushed to the