Re: [PATCH v2] x86/resctrl: fix a NULL vs IS_ERR() static checker warning

2020-06-02 Thread Fenghua Yu
On Tue, Jun 02, 2020 at 10:36:11PM +0300, Dan Carpenter wrote: > The callers don't expect *d_cdp to be set to an error pointer, they only > check for NULL. This leads to a static checker warning: > > arch/x86/kernel/cpu/resctrl/rdtgroup.c:2648 __init_one_rdt_domain() > warn: 'd_cdp'

[PATCH v2] x86/resctrl: fix a NULL vs IS_ERR() static checker warning

2020-06-02 Thread Dan Carpenter
The callers don't expect *d_cdp to be set to an error pointer, they only check for NULL. This leads to a static checker warning: arch/x86/kernel/cpu/resctrl/rdtgroup.c:2648 __init_one_rdt_domain() warn: 'd_cdp' could be an error pointer This would not trigger a bug in this specific case