Re: [PATCH v2] x86/suspend: fix false positive KASAN warning on suspend/resume

2016-12-02 Thread Andrey Ryabinin
On 12/01/2016 11:31 PM, Josh Poimboeuf wrote: > arch/x86/kernel/acpi/wakeup_64.S | 16 > 1 file changed, 16 insertions(+) > > diff --git a/arch/x86/kernel/acpi/wakeup_64.S > b/arch/x86/kernel/acpi/wakeup_64.S > index 169963f..1df9b75 100644 > --- a/arch/x86/kernel/acpi/wakeup

Re: [PATCH v2] x86/suspend: fix false positive KASAN warning on suspend/resume

2016-12-02 Thread Dmitry Vyukov
On Fri, Dec 2, 2016 at 3:01 PM, Josh Poimboeuf wrote: > On Fri, Dec 02, 2016 at 04:41:09PM +0300, Andrey Ryabinin wrote: >> >> >> On 12/01/2016 11:31 PM, Josh Poimboeuf wrote: >> >> > arch/x86/kernel/acpi/wakeup_64.S | 16 >> > 1 file changed, 16 insertions(+) >> > >> > diff --gi

Re: [PATCH v2] x86/suspend: fix false positive KASAN warning on suspend/resume

2016-12-02 Thread Josh Poimboeuf
On Fri, Dec 02, 2016 at 04:41:09PM +0300, Andrey Ryabinin wrote: > > > On 12/01/2016 11:31 PM, Josh Poimboeuf wrote: > > > arch/x86/kernel/acpi/wakeup_64.S | 16 > > 1 file changed, 16 insertions(+) > > > > diff --git a/arch/x86/kernel/acpi/wakeup_64.S > > b/arch/x86/kernel/a

Re: [PATCH v2] x86/suspend: fix false positive KASAN warning on suspend/resume

2016-12-02 Thread Pavel Machek
Hi! > Resuming from a suspend operation is showing a KASAN false positive > warning: > KASAN instrumentation poisons the stack when entering a function and > unpoisons it when exiting the function. However, in the suspend path, > some functions never return, so their stack never gets unpoisoned,

Re: [PATCH v2] x86/suspend: fix false positive KASAN warning on suspend/resume

2016-12-02 Thread Dmitry Vyukov
On Thu, Dec 1, 2016 at 9:31 PM, Josh Poimboeuf wrote: > Resuming from a suspend operation is showing a KASAN false positive > warning: > > BUG: KASAN: stack-out-of-bounds in unwind_get_return_address+0x11d/0x130 at > addr 8803867d7878 > Read of size 8 by task pm-suspend/7774 > page:

[PATCH v2] x86/suspend: fix false positive KASAN warning on suspend/resume

2016-12-01 Thread Josh Poimboeuf
Resuming from a suspend operation is showing a KASAN false positive warning: BUG: KASAN: stack-out-of-bounds in unwind_get_return_address+0x11d/0x130 at addr 8803867d7878 Read of size 8 by task pm-suspend/7774 page:ea000e19f5c0 count:0 mapcount:0 mapping: (null) index:0x0