On Fri, 2015-02-20 at 10:51 -0800, Linus Torvalds wrote:
> On Fri, Feb 20, 2015 at 10:03 AM, Joe Perchens wrote:
> >
> > True. Also fix the pr_debug/dev_dbg cases
> > like drivers/dma/ppc4xx/adma.c:
>
> Yup, that's just garbage, and doesn't actually do what is intended.
>
> Also, rather than
>
On Fri, Feb 20, 2015 at 10:03 AM, Joe Perches wrote:
>
> True. Also fix the pr_debug/dev_dbg cases
> like drivers/dma/ppc4xx/adma.c:
Yup, that's just garbage, and doesn't actually do what is intended.
Also, rather than
pr_debug("\n%s(%d):\nsrc: ", __func__, id);
for (i = 0; i
On Fri, 2015-02-20 at 09:52 -0800, Linus Torvalds wrote:
> On Feb 20, 2015 9:40 AM, "Joe Perches" wrote:
> >
> > There are still a few dozen uses of this pattern:
> >
> > pr_info("Some message line 1\nNext line: ");
> > for (...)
> > pr_cont(" part %d", i);
> >
On Fri, 2015-02-20 at 12:05 -0500, Steven Rostedt wrote:
> On Thu, 19 Feb 2015 21:13:29 -0800
> Linus Torvalds wrote:
>
> > On Feb 19, 2015 8:45 PM, "Steven Rostedt" wrote:
> > >
> > > This looks like a bug in printk(). Why doesn't pr_cont() continue? It
> > > shouldn't care if there's a
On Fri, Feb 20, 2015 at 12:05:06PM -0500, Steven Rostedt wrote:
> printk: Comment pr_cont() stating it is only to continue a line
>
> KERN_CONT is nicely commented in kern_levels.h, but pr_cont() is now
> used more often, and it lacks the comment stating what it is used for.
> It can be confused
On Thu, 19 Feb 2015 21:13:29 -0800
Linus Torvalds wrote:
> On Feb 19, 2015 8:45 PM, "Steven Rostedt" wrote:
> >
> > This looks like a bug in printk(). Why doesn't pr_cont() continue? It
> > shouldn't care if there's a newline or not. pr_cont() is supposed to
> > continue whatever the last
> > Looks like kstack_end() could be defined on 64-bit as well,
> > unifying the stack printing logic some more?
> >
> > ( I'd no go so far as to unify the two functions, but the
> > closer to each other the better it is to make changes
> > that affect both of them. )
>
> Adrien, want to
On Fri, Feb 20, 2015 at 09:10:03AM +0100, Ingo Molnar wrote:
> This approach looks good to me, we want to print multi-line
> messages with the same consistent loglevel.
Right, I'll pick this one up for now as it is obviously correct and
whatever we end up doing to pr_cont() won't influence it.
* Adrien Schildknecht wrote:
> show_stack_log_lvl() does not set the log level after a new line,
> the following messages printed with pr_cont are thus assigned to the
> default log level.
> This patch prepends the log level to the next message following a new
> line.
>
> print_trace_address()
On Fri, Feb 20, 2015 at 09:10:03AM +0100, Ingo Molnar wrote:
This approach looks good to me, we want to print multi-line
messages with the same consistent loglevel.
Right, I'll pick this one up for now as it is obviously correct and
whatever we end up doing to pr_cont() won't influence it.
* Adrien Schildknecht adrien+...@schischi.me wrote:
show_stack_log_lvl() does not set the log level after a new line,
the following messages printed with pr_cont are thus assigned to the
default log level.
This patch prepends the log level to the next message following a new
line.
Looks like kstack_end() could be defined on 64-bit as well,
unifying the stack printing logic some more?
( I'd no go so far as to unify the two functions, but the
closer to each other the better it is to make changes
that affect both of them. )
Adrien, want to take care of
On Thu, 19 Feb 2015 21:13:29 -0800
Linus Torvalds torva...@linux-foundation.org wrote:
On Feb 19, 2015 8:45 PM, Steven Rostedt rost...@goodmis.org wrote:
This looks like a bug in printk(). Why doesn't pr_cont() continue? It
shouldn't care if there's a newline or not. pr_cont() is supposed
On Fri, 2015-02-20 at 12:05 -0500, Steven Rostedt wrote:
On Thu, 19 Feb 2015 21:13:29 -0800
Linus Torvalds torva...@linux-foundation.org wrote:
On Feb 19, 2015 8:45 PM, Steven Rostedt rost...@goodmis.org wrote:
This looks like a bug in printk(). Why doesn't pr_cont() continue? It
On Fri, Feb 20, 2015 at 12:05:06PM -0500, Steven Rostedt wrote:
printk: Comment pr_cont() stating it is only to continue a line
KERN_CONT is nicely commented in kern_levels.h, but pr_cont() is now
used more often, and it lacks the comment stating what it is used for.
It can be confused as
On Fri, 2015-02-20 at 09:52 -0800, Linus Torvalds wrote:
On Feb 20, 2015 9:40 AM, Joe Perches j...@perches.com wrote:
There are still a few dozen uses of this pattern:
pr_info(Some message line 1\nNext line: );
for (...)
pr_cont( part %d, i);
On Fri, Feb 20, 2015 at 10:03 AM, Joe Perches j...@perches.com wrote:
True. Also fix the pr_debug/dev_dbg cases
like drivers/dma/ppc4xx/adma.c:
Yup, that's just garbage, and doesn't actually do what is intended.
Also, rather than
pr_debug(\n%s(%d):\nsrc: , __func__, id);
On Fri, 2015-02-20 at 10:51 -0800, Linus Torvalds wrote:
On Fri, Feb 20, 2015 at 10:03 AM, Joe Perchens j...@perches.com wrote:
True. Also fix the pr_debug/dev_dbg cases
like drivers/dma/ppc4xx/adma.c:
Yup, that's just garbage, and doesn't actually do what is intended.
Also, rather
On Fri, 20 Feb 2015 03:34:21 +0100
Adrien Schildknecht wrote:
> show_stack_log_lvl() does not set the log level after a new line,
> the following messages printed with pr_cont are thus assigned to the
> default log level.
This looks like a bug in printk(). Why doesn't pr_cont() continue? It
show_stack_log_lvl() does not set the log level after a new line,
the following messages printed with pr_cont are thus assigned to the
default log level.
This patch prepends the log level to the next message following a new
line.
print_trace_address() uses printk(log_lvl). Using printk with just
On Fri, 20 Feb 2015 03:34:21 +0100
Adrien Schildknecht adrien+...@schischi.me wrote:
show_stack_log_lvl() does not set the log level after a new line,
the following messages printed with pr_cont are thus assigned to the
default log level.
This looks like a bug in printk(). Why doesn't
show_stack_log_lvl() does not set the log level after a new line,
the following messages printed with pr_cont are thus assigned to the
default log level.
This patch prepends the log level to the next message following a new
line.
print_trace_address() uses printk(log_lvl). Using printk with just
22 matches
Mail list logo
