Re: [PATCH v2] x86: punit_atom: punit device state debug driver

2015-05-04 Thread Thomas Gleixner
On Mon, 4 May 2015, Srinivas Pandruvada wrote: > +struct punit_device { > + char *name; > + int reg; > + int sss_pos; > +}; > + > +static struct punit_device *punit_device; So this pointer gets initialized in punit_atom_debug_init() and points either to punit_device_byt or punit_device

[PATCH v2] x86: punit_atom: punit device state debug driver

2015-05-04 Thread Srinivas Pandruvada
The patch adds a debug driver, which dumps the power states of all the North complex (NC) devices. This debug interface is useful to figure out the devices, which blocks the S0ix transitions on the platform. This is extremely useful during enabling PM on customer platforms and derivatives. This s

[PATCH v2] x86: punit_atom: punit device state debug driver

2015-05-04 Thread Srinivas Pandruvada
v2 Addressed Ingo Molnar's comments - Fix commit message - Added punit explanation - Formatting comments - Moved to arch/x86/platform/intel_mid - changed the debugfs file name v1 Based on review comments - Changed to tristate instead of bool - Moved config to kconfig.debug - Added debug in mod