Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-09 Thread Chentao (Boby)
On 2015/3/6 20:50, Joe Perches wrote: On Fri, 2015-03-06 at 17:33 +0800, Chentao (Boby) wrote: #ifdef pr_fmt #undef pr_fmt #endif #define pr_fmt(fmt) "xen-pvscsi: " fmt No, just use add #define pr_fmt(fmt) "xen-pvscsi: " fmt before the first #include. The #ifdef/#undef/#endif isn't

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-09 Thread Chentao (Boby)
On 2015/3/6 20:50, Joe Perches wrote: On Fri, 2015-03-06 at 17:33 +0800, Chentao (Boby) wrote: #ifdef pr_fmt #undef pr_fmt #endif #define pr_fmt(fmt) xen-pvscsi: fmt No, just use add #define pr_fmt(fmt) xen-pvscsi: fmt before the first #include. The #ifdef/#undef/#endif isn't necessary.

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-06 Thread Joe Perches
On Fri, 2015-03-06 at 17:33 +0800, Chentao (Boby) wrote: > #ifdef pr_fmt > #undef pr_fmt > #endif > #define pr_fmt(fmt) "xen-pvscsi: " fmt No, just use add #define pr_fmt(fmt) "xen-pvscsi: " fmt before the first #include. The #ifdef/#undef/#endif isn't necessary. > Then replace all DPRINTK with

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-06 Thread Chentao (Boby)
On 2015/3/4 18:34, David Vrabel wrote: On 04/03/15 18:32, Tao Chen wrote: Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. Also fixed up some comments just as eliminate redundant white spaces and format the code. These will make the code easier to

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-06 Thread Chentao (Boby)
On 2015/3/5 0:32, Joe Perches wrote: On Wed, 2015-03-04 at 18:32 +, Tao Chen wrote: Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. Also fixed up some comments just as eliminate redundant white spaces and format the code. These will make the

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-06 Thread Joe Perches
On Fri, 2015-03-06 at 17:33 +0800, Chentao (Boby) wrote: #ifdef pr_fmt #undef pr_fmt #endif #define pr_fmt(fmt) xen-pvscsi: fmt No, just use add #define pr_fmt(fmt) xen-pvscsi: fmt before the first #include. The #ifdef/#undef/#endif isn't necessary. Then replace all DPRINTK with pr_debug.

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-06 Thread Chentao (Boby)
On 2015/3/5 0:32, Joe Perches wrote: On Wed, 2015-03-04 at 18:32 +, Tao Chen wrote: Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. Also fixed up some comments just as eliminate redundant white spaces and format the code. These will make the

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-06 Thread Chentao (Boby)
On 2015/3/4 18:34, David Vrabel wrote: On 04/03/15 18:32, Tao Chen wrote: Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. Also fixed up some comments just as eliminate redundant white spaces and format the code. These will make the code easier to

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-04 Thread Joe Perches
On Wed, 2015-03-04 at 18:32 +, Tao Chen wrote: > Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr > sentences and DPRINTK. > Also fixed up some comments just as eliminate redundant white spaces and > format the code. > These will make the code easier to read. It'd

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-04 Thread David Vrabel
On 04/03/15 18:32, Tao Chen wrote: > Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr > sentences and DPRINTK. > Also fixed up some comments just as eliminate redundant white spaces and > format the code. > These will make the code easier to read. I have already said you

[PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-04 Thread Tao Chen
Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. Also fixed up some comments just as eliminate redundant white spaces and format the code. These will make the code easier to read. Signed-off-by: Tao Chen --- drivers/xen/xen-scsiback.c | 70

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-04 Thread Joe Perches
On Wed, 2015-03-04 at 18:32 +, Tao Chen wrote: Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. Also fixed up some comments just as eliminate redundant white spaces and format the code. These will make the code easier to read. It'd probaby

[PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-04 Thread Tao Chen
Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. Also fixed up some comments just as eliminate redundant white spaces and format the code. These will make the code easier to read. Signed-off-by: Tao Chen boby.c...@huawei.com ---

Re: [PATCH v2] xen-scsiback: use DRV_PFX in the pr macros and DPRINTK

2015-03-04 Thread David Vrabel
On 04/03/15 18:32, Tao Chen wrote: Defined the string of {xen-pvscsi: } as DRV_PFX, then use it in the pr sentences and DPRINTK. Also fixed up some comments just as eliminate redundant white spaces and format the code. These will make the code easier to read. I have already said you needed