Re: [PATCH v2] xfs: handle register_shrinker error

On Tue 28-11-17 08:39:19, Darrick J. Wong wrote: > On Tue, Nov 28, 2017 at 10:35:51AM +0100, Michal Hocko wrote: [...] > > Are you going to apply the patch or should I re-send it with > > acks/reviewed-by? > > I injected all of those when I added the patch to my tree: > > Noticed-by: Tetsuo

Re: [PATCH v2] xfs: handle register_shrinker error

On Tue 28-11-17 08:39:19, Darrick J. Wong wrote: > On Tue, Nov 28, 2017 at 10:35:51AM +0100, Michal Hocko wrote: [...] > > Are you going to apply the patch or should I re-send it with > > acks/reviewed-by? > > I injected all of those when I added the patch to my tree: > > Noticed-by: Tetsuo

Re: [PATCH v2] xfs: handle register_shrinker error

On Tue, Nov 28, 2017 at 10:35:51AM +0100, Michal Hocko wrote: > On Mon 27-11-17 09:44:53, Darrick J. Wong wrote: > [...] > > > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > > > From: Michal Hocko > > > Date: Thu, 23 Nov 2017 17:13:40 +0100 > > >

Re: [PATCH v2] xfs: handle register_shrinker error

On Tue, Nov 28, 2017 at 10:35:51AM +0100, Michal Hocko wrote: > On Mon 27-11-17 09:44:53, Darrick J. Wong wrote: > [...] > > > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > > > From: Michal Hocko > > > Date: Thu, 23 Nov 2017 17:13:40 +0100 > > > Subject: [PATCH] xfs:

Re: [PATCH v2] xfs: handle register_shrinker error

On Mon 27-11-17 09:44:53, Darrick J. Wong wrote: [...] > > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Thu, 23 Nov 2017 17:13:40 +0100 > > Subject: [PATCH] xfs: fortify xfs_alloc_buftarg error handling > > > >

Re: [PATCH v2] xfs: handle register_shrinker error

On Mon 27-11-17 09:44:53, Darrick J. Wong wrote: [...] > > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Thu, 23 Nov 2017 17:13:40 +0100 > > Subject: [PATCH] xfs: fortify xfs_alloc_buftarg error handling > > > > percpu_counter_init

Re: [PATCH v2] xfs: handle register_shrinker error

On Fri, Nov 24, 2017 at 08:39:57AM +0100, Michal Hocko wrote: > On Fri 24-11-17 09:00:46, Dave Chinner wrote: > > On Thu, Nov 23, 2017 at 05:11:37PM +0100, Michal Hocko wrote: > > > On Fri 24-11-17 01:01:10, Tetsuo Handa wrote: > > > > Michal Hocko wrote: > > > > > On Thu 23-11-17 05:26:33,

Re: [PATCH v2] xfs: handle register_shrinker error

On Fri, Nov 24, 2017 at 08:39:57AM +0100, Michal Hocko wrote: > On Fri 24-11-17 09:00:46, Dave Chinner wrote: > > On Thu, Nov 23, 2017 at 05:11:37PM +0100, Michal Hocko wrote: > > > On Fri 24-11-17 01:01:10, Tetsuo Handa wrote: > > > > Michal Hocko wrote: > > > > > On Thu 23-11-17 05:26:33,

Re: [PATCH v2] xfs: handle register_shrinker error

On Sun 26-11-17 11:14:25, Tetsuo Handa wrote: > Dave Chinner wrote: > > IOWs, we don't actually need to touch this code, but if you really > > must, just remove the KM_NOFS tag. > > OK. Then, please remove KM_NOFS. GFP_KERNEL is safer than GFP_NOFS > in the sense that it won't cause OOM lockup

Re: [PATCH v2] xfs: handle register_shrinker error

On Sun 26-11-17 11:14:25, Tetsuo Handa wrote: > Dave Chinner wrote: > > IOWs, we don't actually need to touch this code, but if you really > > must, just remove the KM_NOFS tag. > > OK. Then, please remove KM_NOFS. GFP_KERNEL is safer than GFP_NOFS > in the sense that it won't cause OOM lockup

Re: [PATCH v2] xfs: handle register_shrinker error

Dave Chinner wrote: > IOWs, we don't actually need to touch this code, but if you really > must, just remove the KM_NOFS tag. OK. Then, please remove KM_NOFS. GFP_KERNEL is safer than GFP_NOFS in the sense that it won't cause OOM lockup due to unable to invoke the OOM killer.

Re: [PATCH v2] xfs: handle register_shrinker error

Dave Chinner wrote: > IOWs, we don't actually need to touch this code, but if you really > must, just remove the KM_NOFS tag. OK. Then, please remove KM_NOFS. GFP_KERNEL is safer than GFP_NOFS in the sense that it won't cause OOM lockup due to unable to invoke the OOM killer.

Re: [PATCH v2] xfs: handle register_shrinker error

On Fri, Nov 24, 2017 at 09:03:28PM +0900, Tetsuo Handa wrote: > Michal Hocko wrote: > > Thanks. Updated patch below > > --- > > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Thu, 23 Nov 2017 17:13:40 +0100 > > Subject:

Re: [PATCH v2] xfs: handle register_shrinker error

On Fri, Nov 24, 2017 at 09:03:28PM +0900, Tetsuo Handa wrote: > Michal Hocko wrote: > > Thanks. Updated patch below > > --- > > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Thu, 23 Nov 2017 17:13:40 +0100 > > Subject: [PATCH] xfs: fortify

Re: [PATCH v2] xfs: handle register_shrinker error

On Fri 24-11-17 21:03:28, Tetsuo Handa wrote: > Michal Hocko wrote: > > Thanks. Updated patch below > > --- > > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Thu, 23 Nov 2017 17:13:40 +0100 > > Subject: [PATCH] xfs:

Re: [PATCH v2] xfs: handle register_shrinker error

On Fri 24-11-17 21:03:28, Tetsuo Handa wrote: > Michal Hocko wrote: > > Thanks. Updated patch below > > --- > > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > > From: Michal Hocko > > Date: Thu, 23 Nov 2017 17:13:40 +0100 > > Subject: [PATCH] xfs: fortify

Re: [PATCH v2] xfs: handle register_shrinker error

Michal Hocko wrote: > Thanks. Updated patch below > --- > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Thu, 23 Nov 2017 17:13:40 +0100 > Subject: [PATCH] xfs: fortify xfs_alloc_buftarg error handling Do we need below patch

Re: [PATCH v2] xfs: handle register_shrinker error

Michal Hocko wrote: > Thanks. Updated patch below > --- > From 1009db61988c48c9a9e327a9d076945b29b02eee Mon Sep 17 00:00:00 2001 > From: Michal Hocko > Date: Thu, 23 Nov 2017 17:13:40 +0100 > Subject: [PATCH] xfs: fortify xfs_alloc_buftarg error handling Do we need below patch on top of Michal's

[PATCH v2] xfs: handle register_shrinker error

On Fri 24-11-17 09:00:46, Dave Chinner wrote: > On Thu, Nov 23, 2017 at 05:11:37PM +0100, Michal Hocko wrote: > > On Fri 24-11-17 01:01:10, Tetsuo Handa wrote: > > > Michal Hocko wrote: > > > > On Thu 23-11-17 05:26:33, Christoph Hellwig wrote: > > > > > Looks good, > > > > > > > > > >

[PATCH v2] xfs: handle register_shrinker error

On Fri 24-11-17 09:00:46, Dave Chinner wrote: > On Thu, Nov 23, 2017 at 05:11:37PM +0100, Michal Hocko wrote: > > On Fri 24-11-17 01:01:10, Tetsuo Handa wrote: > > > Michal Hocko wrote: > > > > On Thu 23-11-17 05:26:33, Christoph Hellwig wrote: > > > > > Looks good, > > > > > > > > > >