Re: [PATCH v2] xfs: remove kmem_zalloc_greedy

2017-03-15 Thread Darrick J. Wong
On Wed, Mar 15, 2017 at 04:43:27PM +0100, Luis R. Rodriguez wrote: > On Wed, Mar 15, 2017 at 09:35:29AM +0100, Michal Hocko wrote: > > On Wed 15-03-17 01:14:27, Luis R. Rodriguez wrote: > > > On Tue, Mar 14, 2017 at 11:07:38AM -0700, Darrick J. Wong wrote: > > > > On Tue, Mar 14, 2017 at 05:57:45PM

Re: [PATCH v2] xfs: remove kmem_zalloc_greedy

2017-03-15 Thread Luis R. Rodriguez
On Wed, Mar 15, 2017 at 09:35:29AM +0100, Michal Hocko wrote: > On Wed 15-03-17 01:14:27, Luis R. Rodriguez wrote: > > On Tue, Mar 14, 2017 at 11:07:38AM -0700, Darrick J. Wong wrote: > > > On Tue, Mar 14, 2017 at 05:57:45PM +0100, Luis R. Rodriguez wrote: > > > > On Tue, Mar 07, 2017 at 04:35:28PM

Re: [PATCH v2] xfs: remove kmem_zalloc_greedy

2017-03-15 Thread Michal Hocko
On Wed 15-03-17 01:14:27, Luis R. Rodriguez wrote: > On Tue, Mar 14, 2017 at 11:07:38AM -0700, Darrick J. Wong wrote: > > On Tue, Mar 14, 2017 at 05:57:45PM +0100, Luis R. Rodriguez wrote: > > > On Tue, Mar 07, 2017 at 04:35:28PM -0800, Darrick J. Wong wrote: > > > > The sole remaining caller of km

Re: [PATCH v2] xfs: remove kmem_zalloc_greedy

2017-03-14 Thread Luis R. Rodriguez
On Tue, Mar 14, 2017 at 11:07:38AM -0700, Darrick J. Wong wrote: > On Tue, Mar 14, 2017 at 05:57:45PM +0100, Luis R. Rodriguez wrote: > > On Tue, Mar 07, 2017 at 04:35:28PM -0800, Darrick J. Wong wrote: > > > The sole remaining caller of kmem_zalloc_greedy is bulkstat, which uses > > > it to grab 1

Re: [PATCH v2] xfs: remove kmem_zalloc_greedy

2017-03-14 Thread Darrick J. Wong
On Tue, Mar 14, 2017 at 05:57:45PM +0100, Luis R. Rodriguez wrote: > On Tue, Mar 07, 2017 at 04:35:28PM -0800, Darrick J. Wong wrote: > > The sole remaining caller of kmem_zalloc_greedy is bulkstat, which uses > > it to grab 1-4 pages for staging of inobt records. The infinite loop in > > the gree

Re: [PATCH v2] xfs: remove kmem_zalloc_greedy

2017-03-14 Thread Luis R. Rodriguez
On Tue, Mar 07, 2017 at 04:35:28PM -0800, Darrick J. Wong wrote: > The sole remaining caller of kmem_zalloc_greedy is bulkstat, which uses > it to grab 1-4 pages for staging of inobt records. The infinite loop in > the greedy allocation function is causing hangs[1] in generic/269, so > just get ri

[PATCH v2] xfs: remove kmem_zalloc_greedy

2017-03-07 Thread Darrick J. Wong
The sole remaining caller of kmem_zalloc_greedy is bulkstat, which uses it to grab 1-4 pages for staging of inobt records. The infinite loop in the greedy allocation function is causing hangs[1] in generic/269, so just get rid of the greedy allocator in favor of kmem_zalloc_large. This makes bulks

Re: [PATCH v2] xfs: remove kmem_zalloc_greedy

2017-03-07 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig