Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

2013-10-31 Thread Ben Myers
On Fri, Oct 25, 2013 at 10:06:09AM -0500, Ben Myers wrote: > On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote: > > ASSERT on args takes place after args dereference. > > This assertion is redundant since we are going to panic anyway. > > > > Found by Linux Driver Verification project

Re: [PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

2013-10-25 Thread Ben Myers
On Fri, Oct 25, 2013 at 03:53:25PM +0400, Denis Efremov wrote: > ASSERT on args takes place after args dereference. > This assertion is redundant since we are going to panic anyway. > > Found by Linux Driver Verification project (linuxtesting.org) - > PVS-Studio analyzer. > > Signed-off-by: Denis

[PATCH v2] xfs:xfs_dir2_node.c: pointer use before check for null

2013-10-25 Thread Denis Efremov
ASSERT on args takes place after args dereference. This assertion is redundant since we are going to panic anyway. Found by Linux Driver Verification project (linuxtesting.org) - PVS-Studio analyzer. Signed-off-by: Denis Efremov --- fs/xfs/xfs_dir2_node.c | 1 - 1 file changed, 1 deletion(-) d