Re: [PATCH v2 -next] soundwire: Fix -Wunused-function warning

Hi YueHaibing, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20190823] url: https://github.com/0day-ci/linux/commits/YueHaibing/soundwire-Fix-Wunused-function-warning/20190825-083159 config: x86_64-randconfig-g004-201934 (attached as .config) compiler:

Re: [PATCH v2 -next] soundwire: Fix -Wunused-function warning

On 2019/8/23 14:44, Vinod Koul wrote: > On 22-08-19, 22:54, YueHaibing wrote: >> If CONFIG_ACPI is not set, gcc warning this: >> >> drivers/soundwire/slave.c:16:12: warning: >> 'sdw_slave_add' defined but not used [-Wunused-function] >> >> Now all code in slave.c is only used on ACPI enabled, >>

Re: [PATCH v2 -next] soundwire: Fix -Wunused-function warning

On 22-08-19, 22:54, YueHaibing wrote: > If CONFIG_ACPI is not set, gcc warning this: > > drivers/soundwire/slave.c:16:12: warning: > 'sdw_slave_add' defined but not used [-Wunused-function] > > Now all code in slave.c is only used on ACPI enabled, > so compiles it while CONFIG_ACPI is set.

[PATCH v2 -next] soundwire: Fix -Wunused-function warning

If CONFIG_ACPI is not set, gcc warning this: drivers/soundwire/slave.c:16:12: warning: 'sdw_slave_add' defined but not used [-Wunused-function] Now all code in slave.c is only used on ACPI enabled, so compiles it while CONFIG_ACPI is set. Reported-by: Hulk Robot Suggested-by: Ladislav Michl