Re: [PATCH v2 -next] tty: ipwireless: Fix potential NULL pointer dereference

2019-01-31 Thread Jiri Slaby
On 31. 01. 19, 13:32, David Sterba wrote: > This should be mentioned in the changelog though, it's not obvious at > all why just returning after a failure is ok and that the packet will be > resent. Agreed. thanks, -- js suse labs

Re: [PATCH v2 -next] tty: ipwireless: Fix potential NULL pointer dereference

2019-01-31 Thread David Sterba
On Wed, Jan 30, 2019 at 04:58:30PM +0100, Jiri Slaby wrote: > On 30. 01. 19, 11:30, YueHaibing wrote: > > There is a potential NULL pointer dereference in case > > alloc_ctrl_packet() fails and returns NULL. > > > > Fixes: 099dc4fb6265 ("ipwireless: driver for PC Card 3G/UMTS modem") > > Signed-of

Re: [PATCH v2 -next] tty: ipwireless: Fix potential NULL pointer dereference

2019-01-30 Thread Jiri Slaby
On 30. 01. 19, 11:30, YueHaibing wrote: > There is a potential NULL pointer dereference in case > alloc_ctrl_packet() fails and returns NULL. > > Fixes: 099dc4fb6265 ("ipwireless: driver for PC Card 3G/UMTS modem") > Signed-off-by: YueHaibing > --- > v2: fix return value > --- > drivers/tty/ipwi

[PATCH v2 -next] tty: ipwireless: Fix potential NULL pointer dereference

2019-01-30 Thread YueHaibing
There is a potential NULL pointer dereference in case alloc_ctrl_packet() fails and returns NULL. Fixes: 099dc4fb6265 ("ipwireless: driver for PC Card 3G/UMTS modem") Signed-off-by: YueHaibing --- v2: fix return value --- drivers/tty/ipwireless/hardware.c | 2 ++ 1 file changed, 2 insertions(+)