Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-18 Thread Atish Patra
On Tue, 2019-06-18 at 15:02 +0530, Anup Patel wrote: > On Tue, Jun 18, 2019 at 8:56 AM Paul Walmsley < > paul.walms...@sifive.com> wrote: > > On Mon, 17 Jun 2019, Alistair Francis wrote: > > > > > > The legacy M-mode U-boot handles the phy reset already, and > > > > I’ve been > > > > able to load

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-18 Thread Alistair Francis
On Mon, 2019-06-17 at 20:26 -0700, Paul Walmsley wrote: > On Mon, 17 Jun 2019, Alistair Francis wrote: > > > > The legacy M-mode U-boot handles the phy reset already, and I’ve > > > been > > > able to load upstream S-mode uboot as a payload via TFTP, and > > > then > > > load and boot a 4.19 kern

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-18 Thread Troy Benjegerdes
> On Jun 18, 2019, at 4:32 AM, Anup Patel wrote: > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=72296bde4f4207566872ee355950a59cbc29f852 I added your patches, along with two of mine, and rebased them to the latest U-boot master, and put them on the ‘to-upst

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-18 Thread Anup Patel
On Tue, Jun 18, 2019 at 8:56 AM Paul Walmsley wrote: > > On Mon, 17 Jun 2019, Alistair Francis wrote: > > > > The legacy M-mode U-boot handles the phy reset already, and I’ve been > > > able to load upstream S-mode uboot as a payload via TFTP, and then > > > load and boot a 4.19 kernel. > > > > >

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Paul Walmsley
On Mon, 17 Jun 2019, Alistair Francis wrote: > > The legacy M-mode U-boot handles the phy reset already, and I’ve been > > able to load upstream S-mode uboot as a payload via TFTP, and then > > load and boot a 4.19 kernel. > > > > It would be nice to get this all working with 5.x, however there

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Alistair Francis
On Mon, 2019-06-17 at 09:14 -0500, Troy Benjegerdes wrote: > > On Jun 17, 2019, at 6:34 AM, Paul Walmsley < > > paul.walms...@sifive.com> wrote: > > > > On Mon, 17 Jun 2019, Andreas Schwab wrote: > > > > > On Jun 17 2019, Paul Walmsley wrote: > > > > > > > On Mon, 17 Jun 2019, Andreas Schwab wr

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Paul Walmsley
On Mon, 17 Jun 2019, Troy Benjegerdes wrote: > Have we documented this tx clock switch register in something with a > direct URL link (rather than a PDF)? The SiFive FU540 user manual PDF is the canonical public reference: https://static.dev.sifive.com/FU540-C000-v1.0.pdf This practice aligns w

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Troy Benjegerdes
> On Jun 17, 2019, at 6:34 AM, Paul Walmsley wrote: > > On Mon, 17 Jun 2019, Andreas Schwab wrote: > >> On Jun 17 2019, Paul Walmsley wrote: >> >>> On Mon, 17 Jun 2019, Andreas Schwab wrote: >>> On Jun 17 2019, Paul Walmsley wrote: > Looks to me that it shouldn't have an im

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Paul Walmsley
On Mon, 17 Jun 2019, Andreas Schwab wrote: > On Jun 17 2019, Paul Walmsley wrote: > > > On Mon, 17 Jun 2019, Andreas Schwab wrote: > > > >> On Jun 17 2019, Paul Walmsley wrote: > >> > >> > Looks to me that it shouldn't have an impact unless the DT string is > >> > present, and even then, the

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Yash Shah
On Mon, Jun 17, 2019 at 3:58 PM Paul Walmsley wrote: > > On Mon, 17 Jun 2019, Yash Shah wrote: > > > On Mon, Jun 17, 2019 at 3:28 PM Paul Walmsley > > wrote: > > > > > On Mon, 17 Jun 2019, Andreas Schwab wrote: > > > > > > > On Jun 17 2019, Yash Shah wrote: > > > > > > > > > - Add "MACB_SIFIVE_

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Paul Walmsley
On Mon, 17 Jun 2019, Yash Shah wrote: > On Mon, Jun 17, 2019 at 3:28 PM Paul Walmsley > wrote: > > > On Mon, 17 Jun 2019, Andreas Schwab wrote: > > > > > On Jun 17 2019, Yash Shah wrote: > > > > > > > - Add "MACB_SIFIVE_FU540" in Kconfig to support SiFive FU540 in macb > > > > driver. This is

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Yash Shah
On Mon, Jun 17, 2019 at 3:28 PM Paul Walmsley wrote: > > Hi Yash, > > On Mon, 17 Jun 2019, Andreas Schwab wrote: > > > On Jun 17 2019, Yash Shah wrote: > > > > > - Add "MACB_SIFIVE_FU540" in Kconfig to support SiFive FU540 in macb > > > driver. This is needed because on FU540, the macb driver d

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Andreas Schwab
On Jun 17 2019, Paul Walmsley wrote: > On Mon, 17 Jun 2019, Andreas Schwab wrote: > >> On Jun 17 2019, Paul Walmsley wrote: >> >> > Looks to me that it shouldn't have an impact unless the DT string is >> > present, and even then, the impact might simply be that the MACB driver >> > may not wo

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Paul Walmsley
On Mon, 17 Jun 2019, Andreas Schwab wrote: > On Jun 17 2019, Paul Walmsley wrote: > > > Looks to me that it shouldn't have an impact unless the DT string is > > present, and even then, the impact might simply be that the MACB driver > > may not work? > > If the macb driver doesn't work you ha

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Andreas Schwab
On Jun 17 2019, Paul Walmsley wrote: > Looks to me that it shouldn't have an impact unless the DT string is > present, and even then, the impact might simply be that the MACB driver > may not work? If the macb driver doesn't work you have an unusable system, of course. Andreas. -- Andreas S

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Paul Walmsley
Hi Yash, On Mon, 17 Jun 2019, Andreas Schwab wrote: > On Jun 17 2019, Yash Shah wrote: > > > - Add "MACB_SIFIVE_FU540" in Kconfig to support SiFive FU540 in macb > > driver. This is needed because on FU540, the macb driver depends on > > SiFive GPIO driver. > > This of course requires that

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-17 Thread Andreas Schwab
On Jun 17 2019, Yash Shah wrote: > - Add "MACB_SIFIVE_FU540" in Kconfig to support SiFive FU540 in macb > driver. This is needed because on FU540, the macb driver depends on > SiFive GPIO driver. This of course requires that the GPIO driver is upstreamed first. Andreas. -- Andreas Schwab,

Re: [PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-16 Thread Yash Shah
On Mon, Jun 17, 2019 at 9:49 AM Yash Shah wrote: > > On FU540, the management IP block is tightly coupled with the Cadence > MACB IP block. It manages many of the boundary signals from the MACB IP > This patchset controls the tx_clk input signal to the MACB IP. It > switches between the local TX c

[PATCH v2 0/2] Add macb support for SiFive FU540-C000

2019-06-16 Thread Yash Shah
On FU540, the management IP block is tightly coupled with the Cadence MACB IP block. It manages many of the boundary signals from the MACB IP This patchset controls the tx_clk input signal to the MACB IP. It switches between the local TX clock (125MHz) and PHY TX clocks. This is necessary to toggle