Re: [PATCH v2 0/2] mm/kasan: dump alloc/free stack for page allocator

2019-09-10 Thread Walter Wu
On Tue, 2019-09-10 at 13:53 +0200, Vlastimil Babka wrote: > On 9/10/19 12:50 PM, Andrey Ryabinin wrote: > > > > > > For slab objects we memorize both alloc and free stacks. You'll never know > > in advance what information will be usefull > > to fix an issue, so it usually better to provide

Re: [PATCH v2 0/2] mm/kasan: dump alloc/free stack for page allocator

2019-09-10 Thread Walter Wu
On Tue, 2019-09-10 at 13:50 +0300, Andrey Ryabinin wrote: > > On 9/9/19 4:07 PM, Vlastimil Babka wrote: > > On 9/9/19 10:24 AM, walter-zh...@mediatek.com wrote: > >> From: Walter Wu > >> > >> This patch is KASAN report adds the alloc/free stacks for page allocator > >> in order to help

Re: [PATCH v2 0/2] mm/kasan: dump alloc/free stack for page allocator

2019-09-10 Thread Vlastimil Babka
On 9/10/19 12:50 PM, Andrey Ryabinin wrote: For slab objects we memorize both alloc and free stacks. You'll never know in advance what information will be usefull to fix an issue, so it usually better to provide more information. I don't think we should do anything different for pages.

Re: [PATCH v2 0/2] mm/kasan: dump alloc/free stack for page allocator

2019-09-10 Thread Andrey Ryabinin
On 9/9/19 4:07 PM, Vlastimil Babka wrote: > On 9/9/19 10:24 AM, walter-zh...@mediatek.com wrote: >> From: Walter Wu >> >> This patch is KASAN report adds the alloc/free stacks for page allocator >> in order to help programmer to see memory corruption caused by page. >> >> By default, KASAN

Re: [PATCH v2 0/2] mm/kasan: dump alloc/free stack for page allocator

2019-09-10 Thread Walter Wu
On Mon, 2019-09-09 at 16:24 +0800, walter-zh...@mediatek.com wrote: > From: Walter Wu > > This patch is KASAN report adds the alloc/free stacks for page allocator > in order to help programmer to see memory corruption caused by page. > > By default, KASAN doesn't record alloc and free stack for

Re: [PATCH v2 0/2] mm/kasan: dump alloc/free stack for page allocator

2019-09-09 Thread Vlastimil Babka
On 9/9/19 10:24 AM, walter-zh...@mediatek.com wrote: From: Walter Wu This patch is KASAN report adds the alloc/free stacks for page allocator in order to help programmer to see memory corruption caused by page. By default, KASAN doesn't record alloc and free stack for page allocator. It is

[PATCH v2 0/2] mm/kasan: dump alloc/free stack for page allocator

2019-09-09 Thread walter-zh.wu
From: Walter Wu This patch is KASAN report adds the alloc/free stacks for page allocator in order to help programmer to see memory corruption caused by page. By default, KASAN doesn't record alloc and free stack for page allocator. It is difficult to fix up page use-after-free or dobule-free