Re: [PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-03-08 Thread Jiri Kosina
On Tue, 7 Mar 2017, Tomasz Kramkowski wrote: > I'll post it on here as a patch. I'm not sure if that would be a v3 or a > new patch. As the baseline patch is already merged and I am not rebasing hid.git, please send anything else as a followup fix. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-03-08 Thread Jiri Kosina
On Tue, 7 Mar 2017, Tomasz Kramkowski wrote: > I'll post it on here as a patch. I'm not sure if that would be a v3 or a > new patch. As the baseline patch is already merged and I am not rebasing hid.git, please send anything else as a followup fix. Thanks, -- Jiri Kosina SUSE Labs

Re: [PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-03-07 Thread Tomasz Kramkowski
On Mon, Mar 06, 2017 at 10:04:50AM +0100, Benjamin Tissoires wrote: > Well, the HID spec is not very clear, that the least we can agree on :) > > But Microsoft's interpretation is rather clear in the > multitouch/touchpad/pen specification: >

Re: [PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-03-07 Thread Tomasz Kramkowski
On Mon, Mar 06, 2017 at 10:04:50AM +0100, Benjamin Tissoires wrote: > Well, the HID spec is not very clear, that the least we can agree on :) > > But Microsoft's interpretation is rather clear in the > multitouch/touchpad/pen specification: >

Re: [PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-03-06 Thread Benjamin Tissoires
On Mar 04 2017 or thereabouts, Tomasz Kramkowski wrote: > On Fri, Mar 03, 2017 at 05:15:01PM +0100, Benjamin Tissoires wrote: > > > Firstly, the value reported by the device is still unusual and does not > > > correctly represent the state of the device. > > > > That's a little bit worrying. I

Re: [PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-03-06 Thread Benjamin Tissoires
On Mar 04 2017 or thereabouts, Tomasz Kramkowski wrote: > On Fri, Mar 03, 2017 at 05:15:01PM +0100, Benjamin Tissoires wrote: > > > Firstly, the value reported by the device is still unusual and does not > > > correctly represent the state of the device. > > > > That's a little bit worrying. I

Re: [PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-03-04 Thread Tomasz Kramkowski
On Fri, Mar 03, 2017 at 05:15:01PM +0100, Benjamin Tissoires wrote: > > Firstly, the value reported by the device is still unusual and does not > > correctly represent the state of the device. > > That's a little bit worrying. I still think the patch could be taken, > but it would be interesting

Re: [PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-03-04 Thread Tomasz Kramkowski
On Fri, Mar 03, 2017 at 05:15:01PM +0100, Benjamin Tissoires wrote: > > Firstly, the value reported by the device is still unusual and does not > > correctly represent the state of the device. > > That's a little bit worrying. I still think the patch could be taken, > but it would be interesting

Re: [PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-03-03 Thread Benjamin Tissoires
Hi, After some checks on the devices I have and the history of the code, I think the patch in this form is correct: Acked-By: Benjamin Tissoires Actually, in the discussion that introduced those checks, there was even a mention of checking the NULL state byte.

Re: [PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-03-03 Thread Benjamin Tissoires
Hi, After some checks on the devices I have and the history of the code, I think the patch in this form is correct: Acked-By: Benjamin Tissoires Actually, in the discussion that introduced those checks, there was even a mention of checking the NULL state byte. Unfortunately, it didn't end up

[PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-02-14 Thread Tomasz Kramkowski
I apologise sincerely for sitting on these patches for so long, aside from other tasks I was busy with, I have found it very difficult to try to correctly interpret the HID specification on this topic and then to try to word my explanation below. As agreed on the list, I have looked into the

[PATCH v2 0/2] patches for Innomedia INNEX GENESIS/ATARI adapter

2017-02-14 Thread Tomasz Kramkowski
I apologise sincerely for sitting on these patches for so long, aside from other tasks I was busy with, I have found it very difficult to try to correctly interpret the HID specification on this topic and then to try to word my explanation below. As agreed on the list, I have looked into the