Re: [PATCH v2 0/3] md superblock write alignment on 512e devices

2020-11-04 Thread Xiao Ni
On 11/04/2020 04:12 AM, Chris Unkel wrote: Hi Xiao, Thanks for the excellent feedback. Since bitmap_offset appears to be a free-form field, it wasn't apparent to me that the bitmap never starts within 4K of the bitmap. I don't think it's worth worrying about a logical block size that's more

Re: [PATCH v2 0/3] md superblock write alignment on 512e devices

2020-11-03 Thread Chris Unkel
Hi Xiao, Thanks for the excellent feedback. Since bitmap_offset appears to be a free-form field, it wasn't apparent to me that the bitmap never starts within 4K of the bitmap. I don't think it's worth worrying about a logical block size that's more than 4K here--from what I can see logical block

Re: [PATCH v2 0/3] md superblock write alignment on 512e devices

2020-11-01 Thread Xiao Ni
On 10/30/2020 04:13 AM, Christopher Unkel wrote: Hello, Thanks for the feedback on the previous patch series. A updated patch series with the same function as the first patch (https://lkml.org/lkml/2020/10/22/1058 "md: align superblock writes to physical blocks") follows. As suggested, it i

[PATCH v2 0/3] md superblock write alignment on 512e devices

2020-10-29 Thread Christopher Unkel
Hello, Thanks for the feedback on the previous patch series. A updated patch series with the same function as the first patch (https://lkml.org/lkml/2020/10/22/1058 "md: align superblock writes to physical blocks") follows. As suggested, it introduces a helper function, which can be used to redu