Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-23 Thread Benjamin Tissoires
On Thu, Feb 22, 2018 at 6:48 PM, Rodrigo Rivas Costa wrote: > On Thu, Feb 22, 2018 at 06:06:30PM +0100, Benjamin Tissoires wrote: >> On Thu, Feb 22, 2018 at 5:31 PM, Rodrigo Rivas Costa >> wrote: >> > On Thu, Feb 22, 2018 at 10:10:40AM +0100, Benjamin Tissoires wrote: >> >> On Thu, Feb 22, 2018 a

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-22 Thread Rodrigo Rivas Costa
On Thu, Feb 22, 2018 at 06:06:30PM +0100, Benjamin Tissoires wrote: > On Thu, Feb 22, 2018 at 5:31 PM, Rodrigo Rivas Costa > wrote: > > On Thu, Feb 22, 2018 at 10:10:40AM +0100, Benjamin Tissoires wrote: > >> On Thu, Feb 22, 2018 at 1:13 AM, Pierre-Loup A. Griffais > >> wrote: > >> > > >> > > >>

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-22 Thread Benjamin Tissoires
On Thu, Feb 22, 2018 at 5:31 PM, Rodrigo Rivas Costa wrote: > On Thu, Feb 22, 2018 at 10:10:40AM +0100, Benjamin Tissoires wrote: >> On Thu, Feb 22, 2018 at 1:13 AM, Pierre-Loup A. Griffais >> wrote: >> > >> > >> > On 02/21/2018 12:21 PM, Rodrigo Rivas Costa wrote: >> >> >> >> On Tue, Feb 20, 201

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-22 Thread Rodrigo Rivas Costa
On Thu, Feb 22, 2018 at 10:10:40AM +0100, Benjamin Tissoires wrote: > On Thu, Feb 22, 2018 at 1:13 AM, Pierre-Loup A. Griffais > wrote: > > > > > > On 02/21/2018 12:21 PM, Rodrigo Rivas Costa wrote: > >> > >> On Tue, Feb 20, 2018 at 04:09:39PM -0800, Pierre-Loup A. Griffais wrote: > >>> > >>> On 0

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-22 Thread Benjamin Tissoires
On Thu, Feb 22, 2018 at 1:13 AM, Pierre-Loup A. Griffais wrote: > > > On 02/21/2018 12:21 PM, Rodrigo Rivas Costa wrote: >> >> On Tue, Feb 20, 2018 at 04:09:39PM -0800, Pierre-Loup A. Griffais wrote: >>> >>> On 02/20/2018 03:20 PM, Rodrigo Rivas Costa wrote: On Tue, Feb 20, 2018 at 02:29

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-22 Thread Clément VUCHENER
2018-02-22 1:13 GMT+01:00 Pierre-Loup A. Griffais : > > On 02/21/2018 12:21 PM, Rodrigo Rivas Costa wrote: >> >> Related to that, Benjamin Tissoires replied to 1/3: --- a/drivers/hid/hid-quirks.c +++ b/drivers/hid/hid-quirks.c @@ -629,6 +629,10 @@ static const struct hid_device_

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-21 Thread Pierre-Loup A. Griffais
On 02/21/2018 12:21 PM, Rodrigo Rivas Costa wrote: On Tue, Feb 20, 2018 at 04:09:39PM -0800, Pierre-Loup A. Griffais wrote: On 02/20/2018 03:20 PM, Rodrigo Rivas Costa wrote: On Tue, Feb 20, 2018 at 02:29:48PM -0800, Pierre-Loup A. Griffais wrote: About the left trackpad/joystick, currently I

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-21 Thread Rodrigo Rivas Costa
On Tue, Feb 20, 2018 at 04:09:39PM -0800, Pierre-Loup A. Griffais wrote: > On 02/20/2018 03:20 PM, Rodrigo Rivas Costa wrote: > > On Tue, Feb 20, 2018 at 02:29:48PM -0800, Pierre-Loup A. Griffais wrote: > > About the left trackpad/joystick, currently I'm not treating them > > different. I'm out of

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-21 Thread Rodrigo Rivas Costa
On Wed, Feb 21, 2018 at 11:39:49AM +0100, Clément VUCHENER wrote: > Hi Rodrigo, Hello, Clément! > I have written a kernel driver [1], some time ago. I did not submit it > for merging in the main-line because I thought that would mess with > user-space drivers. If your driver create an input devic

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-21 Thread Clément VUCHENER
Hi Rodrigo, I have written a kernel driver [1], some time ago. I did not submit it for merging in the main-line because I thought that would mess with user-space drivers. If your driver create an input device, a user-space driver will have to disable it before creating its own. I guess libusb base

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-20 Thread Pierre-Loup A. Griffais
On 02/20/2018 03:20 PM, Rodrigo Rivas Costa wrote: On Tue, Feb 20, 2018 at 02:29:48PM -0800, Pierre-Loup A. Griffais wrote: Hi Rodrigo, Thanks for working on that! I have a few questions and remarks. For the reverse-engineering part, there's a lot of existing reference in existing (user-space)

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-20 Thread Rodrigo Rivas Costa
On Tue, Feb 20, 2018 at 02:29:48PM -0800, Pierre-Loup A. Griffais wrote: > Hi Rodrigo, > > Thanks for working on that! I have a few questions and remarks. > > For the reverse-engineering part, there's a lot of existing reference in > existing (user-space) drivers for the controllers like sc-contr

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-20 Thread Pierre-Loup A. Griffais
Hi Rodrigo, Thanks for working on that! I have a few questions and remarks. For the reverse-engineering part, there's a lot of existing reference in existing (user-space) drivers for the controllers like sc-controller, but feel free to reach out if you have any questions. It's overall pretty

[PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-20 Thread Rodrigo Rivas Costa
This patchset implements a driver for Valve Steam Controller, based on a reverse analysis by myself. Notable changes from patchset v1: * Remove references to USB. Now the interesting interfaces are selected by looking for the ones with feature reports. * Feature reports buffers are allocated