Re: [PATCH v2 0/3] tracing: a few simplifying patches

2018-10-31 Thread Steven Rostedt
On Mon, 29 Oct 2018 23:35:39 +0100 Rasmus Villemoes wrote: Hi Rasmus, I'm currently traveling. I'll try to take a look at these later. If you don't hear from me by next week, feel free to send me a gentle reminder ;-) -- Steve > Playing around with -Wformat-nonliteral, I stumbled on two

Re: [PATCH v2 0/3] tracing: a few simplifying patches

2018-10-31 Thread Steven Rostedt
On Mon, 29 Oct 2018 23:35:39 +0100 Rasmus Villemoes wrote: Hi Rasmus, I'm currently traveling. I'll try to take a look at these later. If you don't hear from me by next week, feel free to send me a gentle reminder ;-) -- Steve > Playing around with -Wformat-nonliteral, I stumbled on two

[PATCH v2 0/3] tracing: a few simplifying patches

2018-10-29 Thread Rasmus Villemoes
Playing around with -Wformat-nonliteral, I stumbled on two instances in trace_output.c. Looking at the code a bit, turns out one can remove the use of the non-constant format string and eliminate some code duplication at the same time. v2: Include cover letter, rename argument with_offset ->

[PATCH v2 0/3] tracing: a few simplifying patches

2018-10-29 Thread Rasmus Villemoes
Playing around with -Wformat-nonliteral, I stumbled on two instances in trace_output.c. Looking at the code a bit, turns out one can remove the use of the non-constant format string and eliminate some code duplication at the same time. v2: Include cover letter, rename argument with_offset ->