Re: [PATCH v2 0/3] x86: kprobes: Show correct blaclkist in debugfs

2019-01-01 Thread Andrea Righi
On Tue, Jan 01, 2019 at 10:16:54PM +0900, Masami Hiramatsu wrote: ... > > > > > Do you see a nice and clean way to blacklist all these functions > > > > > (something like arch_populate_kprobe_blacklist()), or should we just > > > > > flag all of them explicitly with NOKPROBE_SYMBOL()? > > > > > >

Re: [PATCH v2 0/3] x86: kprobes: Show correct blaclkist in debugfs

2019-01-01 Thread Masami Hiramatsu
Hi Andrea, Sorry for late reply, On Thu, 27 Dec 2018 18:09:34 +0100 Andrea Righi wrote: > On Tue, Dec 18, 2018 at 06:24:35PM +0100, Andrea Righi wrote:, > > On Tue, Dec 18, 2018 at 01:50:26PM +0900, Masami Hiramatsu wrote: > > ... > > > > Side question: there are certain symbols in

Re: [PATCH v2 0/3] x86: kprobes: Show correct blaclkist in debugfs

2018-12-27 Thread Andrea Righi
On Tue, Dec 18, 2018 at 06:24:35PM +0100, Andrea Righi wrote: > On Tue, Dec 18, 2018 at 01:50:26PM +0900, Masami Hiramatsu wrote: > ... > > > Side question: there are certain symbols in arch/x86/xen that should be > > > blacklisted explicitly, because they're non-attachable. > > > > > > More

Re: [PATCH v2 0/3] x86: kprobes: Show correct blaclkist in debugfs

2018-12-18 Thread Andrea Righi
On Tue, Dec 18, 2018 at 01:50:26PM +0900, Masami Hiramatsu wrote: ... > > Side question: there are certain symbols in arch/x86/xen that should be > > blacklisted explicitly, because they're non-attachable. > > > > More exactly, all functions defined in arch/x86/xen/spinlock.c, > >

Re: [PATCH v2 0/3] x86: kprobes: Show correct blaclkist in debugfs

2018-12-17 Thread Masami Hiramatsu
On Mon, 17 Dec 2018 16:47:13 +0100 Andrea Righi wrote: > On Mon, Dec 17, 2018 at 05:20:25PM +0900, Masami Hiramatsu wrote: > > This is v2 series for showing correct kprobe blacklist in > > debugfs. > > > > v1 is here: > > > > https://lkml.org/lkml/2018/12/7/517 > > > > I splitted the RFC v1

Re: [PATCH v2 0/3] x86: kprobes: Show correct blaclkist in debugfs

2018-12-17 Thread Andrea Righi
On Mon, Dec 17, 2018 at 05:20:25PM +0900, Masami Hiramatsu wrote: > This is v2 series for showing correct kprobe blacklist in > debugfs. > > v1 is here: > > https://lkml.org/lkml/2018/12/7/517 > > I splitted the RFC v1 patch into x86 and generic parts, > also added a patch to remove unneeded

[PATCH v2 0/3] x86: kprobes: Show correct blaclkist in debugfs

2018-12-17 Thread Masami Hiramatsu
This is v2 series for showing correct kprobe blacklist in debugfs. v1 is here: https://lkml.org/lkml/2018/12/7/517 I splitted the RFC v1 patch into x86 and generic parts, also added a patch to remove unneeded arch-specific blacklist check function (because those have been added to the generic