Re: [PATCH v2 0/4] Introduce the Counter character device interface

2020-06-02 Thread William Breathitt Gray
On Tue, Jun 02, 2020 at 10:18:07AM -0500, David Lechner wrote: > On 5/31/20 12:14 PM, William Breathitt Gray wrote: > > Yielding the following /dev/counter0 memory layout: > > > > ++-++---+ > > | Byte 0 | Byte 1 - Byte 8 | Byte 9 | By

Re: [PATCH v2 0/4] Introduce the Counter character device interface

2020-06-02 Thread David Lechner
On 5/31/20 12:14 PM, William Breathitt Gray wrote: Yielding the following /dev/counter0 memory layout: ++-++---+ | Byte 0 | Byte 1 - Byte 8 | Byte 9 | Byte 10 - Byte 17 | ++-++

Re: [PATCH v2 0/4] Introduce the Counter character device interface

2020-06-01 Thread Jonathan Cameron
On Sun, 31 May 2020 13:14:06 -0400 William Breathitt Gray wrote: > On Sun, May 31, 2020 at 04:18:13PM +0100, Jonathan Cameron wrote: > > On Sun, 24 May 2020 13:54:39 -0400 > > William Breathitt Gray wrote: > > > After giving this some more thought, I believe human-readable sysfs > > > attribut

Re: [PATCH v2 0/4] Introduce the Counter character device interface

2020-05-31 Thread William Breathitt Gray
On Sun, May 31, 2020 at 04:18:13PM +0100, Jonathan Cameron wrote: > On Sun, 24 May 2020 13:54:39 -0400 > William Breathitt Gray wrote: > > After giving this some more thought, I believe human-readable sysfs > > attributes are the way to go to support configuration of the character > > device. I am

Re: [PATCH v2 0/4] Introduce the Counter character device interface

2020-05-31 Thread Jonathan Cameron
On Sun, 24 May 2020 13:54:39 -0400 William Breathitt Gray wrote: > On Sun, May 24, 2020 at 05:25:42PM +0100, Jonathan Cameron wrote: > > > > ... > > > > > The following are some questions I have about this patchset: > > > > > > 1. Should the data format of the character device be configured

Re: [PATCH v2 0/4] Introduce the Counter character device interface

2020-05-24 Thread William Breathitt Gray
On Sun, May 24, 2020 at 05:25:42PM +0100, Jonathan Cameron wrote: > > ... > > > The following are some questions I have about this patchset: > > > > 1. Should the data format of the character device be configured via a > >sysfs attribute? > > > >In this patchset, the first 196095 bytes

Re: [PATCH v2 0/4] Introduce the Counter character device interface

2020-05-24 Thread Jonathan Cameron
... > The following are some questions I have about this patchset: > > 1. Should the data format of the character device be configured via a >sysfs attribute? > >In this patchset, the first 196095 bytes of the character device are >dedicated as a selection area to choose which Coun

[PATCH v2 0/4] Introduce the Counter character device interface

2020-05-16 Thread William Breathitt Gray
Changes in v2: - Use fixed-width data types to represent Counter data types - Use union of function prototypes to store read/write callbacks - Eliminate the counter-strings and counter-sysfs-callback files by inlining relevant code - Reimplement chrdev code to handle read/write calls instead