Re: [PATCH v2 0/4] fujitsu_init() cleanup

2017-03-07 Thread Michał Kępień
> Hi Michael > > On Mon, Mar 06, 2017 at 07:47:23PM +0100, Micha?? K??pie?? wrote: > > > > In light of the above findings, what would you like to do? > > > > > > Thanks for testing, good that we caught this before the patch series was > > > applied. I think it is reasonable to skip applying this

Re: [PATCH v2 0/4] fujitsu_init() cleanup

2017-03-06 Thread Jonathan Woithe
Hi Michael On Mon, Mar 06, 2017 at 07:47:23PM +0100, Micha?? K??pie?? wrote: > > > In light of the above findings, what would you like to do? > > > > Thanks for testing, good that we caught this before the patch series was > > applied. I think it is reasonable to skip applying this version of th

Re: [PATCH v2 0/4] fujitsu_init() cleanup

2017-03-06 Thread Michał Kępień
> > Hi Michael > > > > Some quick feedback. > > > > On Mon, Mar 06, 2017 at 03:31:04PM +1030, Jonathan Woithe wrote: > > > > > I can add that immediately after loading the driver the value > > > > > returned by a > > > > > read of bl_power is 0. As noted above, setting to 1 makes no > > > > >

Re: [PATCH v2 0/4] fujitsu_init() cleanup

2017-03-06 Thread Michał Kępień
> Hi Michael > > Some quick feedback. > > On Mon, Mar 06, 2017 at 03:31:04PM +1030, Jonathan Woithe wrote: > > > > I can add that immediately after loading the driver the value returned > > > > by a > > > > read of bl_power is 0. As noted above, setting to 1 makes no > > > > difference to > >

Re: [PATCH v2 0/4] fujitsu_init() cleanup

2017-03-06 Thread Jonathan Woithe
Hi Michael Some quick feedback. On Mon, Mar 06, 2017 at 03:31:04PM +1030, Jonathan Woithe wrote: > > > I can add that immediately after loading the driver the value returned by > > > a > > > read of bl_power is 0. As noted above, setting to 1 makes no difference > > > to > > > the backlight, n

Re: [PATCH v2 0/4] fujitsu_init() cleanup

2017-03-05 Thread Jonathan Woithe
Hi Michael On Mon, Mar 06, 2017 at 05:49:05AM +0100, Micha?? K??pie?? wrote: > > > With regard to patch 2/4 you wrote: > > > > Jonathan, this *really* needs testing on relevant hardware. After > > > > applying this patch, you should be able to turn LCD backlight on and off > > > > using /sys/clas

Re: [PATCH v2 0/4] fujitsu_init() cleanup

2017-03-05 Thread Michał Kępień
Hi Jonathan, Thanks for testing this series. > Hi Michael > > On Sat, Mar 04, 2017 at 12:17:23PM +1030, Jonathan Woithe wrote: > > On Wed, Mar 01, 2017 at 09:10:40AM +0100, Micha?? K??pie?? wrote: > > > These patches should make fujitsu_init() a bit more palatable. No > > > changes are made to

Re: [PATCH v2 0/4] fujitsu_init() cleanup

2017-03-05 Thread Jonathan Woithe
Hi Michael On Sat, Mar 04, 2017 at 12:17:23PM +1030, Jonathan Woithe wrote: > On Wed, Mar 01, 2017 at 09:10:40AM +0100, Micha?? K??pie?? wrote: > > These patches should make fujitsu_init() a bit more palatable. No > > changes are made to platform device code yet, for clarity these will be > > pos

Re: [PATCH v2 0/4] fujitsu_init() cleanup

2017-03-03 Thread Jonathan Woithe
Hi Michael On Wed, Mar 01, 2017 at 09:10:40AM +0100, Micha?? K??pie?? wrote: > These patches should make fujitsu_init() a bit more palatable. No > changes are made to platform device code yet, for clarity these will be > posted in a separate series after this one gets applied. I have a prelimina

Re: [PATCH v2 0/4] fujitsu_init() cleanup

2017-03-03 Thread Jonathan Woithe
On Thu, Mar 02, 2017 at 08:19:38AM +0100, Micha?? K??pie?? wrote: > > On Wed, Mar 01, 2017 at 09:10:40AM +0100, Micha?? K??pie?? wrote: > > > These patches should make fujitsu_init() a bit more palatable. No > > > changes are made to platform device code yet, for clarity these will be > > > posted

Re: [PATCH v2 0/4] fujitsu_init() cleanup

2017-03-02 Thread Michał Kępień
> On Wed, Mar 01, 2017 at 09:10:40AM +0100, Micha?? K??pie?? wrote: > > These patches should make fujitsu_init() a bit more palatable. No > > changes are made to platform device code yet, for clarity these will be > > posted in a separate series after this one gets applied. > > Thanks for these.

Re: [PATCH v2 0/4] fujitsu_init() cleanup [resend due to vger error]

2017-03-01 Thread Jonathan Woithe
On Wed, Mar 01, 2017 at 09:10:40AM +0100, Micha?? K??pie?? wrote: > These patches should make fujitsu_init() a bit more palatable. No > changes are made to platform device code yet, for clarity these will be > posted in a separate series after this one gets applied. Thanks for these. As for the

[PATCH v2 0/4] fujitsu_init() cleanup

2017-03-01 Thread Michał Kępień
These patches should make fujitsu_init() a bit more palatable. No changes are made to platform device code yet, for clarity these will be posted in a separate series after this one gets applied. Changes from v1: - Rebase on top of reworked Alan Jenkins' cleanup patch series. - Drop patch 1/