Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-30 Thread Toshi Kani
On Thu, 2012-11-29 at 10:25 +0800, Jiang Liu wrote: > On 2012-11-29 9:42, Jaegeuk Hanse wrote: > > On Wed, Nov 28, 2012 at 04:47:42PM +0800, Jiang Liu wrote: > >> Hi all, > >>Seems it's a great chance to discuss about the memory hotplug feature > >> within this thread. So I will try to give som

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-30 Thread Jiang Liu
On 11/30/2012 11:15 AM, Yasuaki Ishimatsu wrote: > Hi Jiang, > >> >> For the first issue, I think we could automatically convert pages >> from movable zones into normal zones. Congyan from Fujitsu has provided >> a patchset to manually convert pages from movable zones into normal zones, >> I think

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-30 Thread Mel Gorman
On Fri, Nov 30, 2012 at 02:58:40AM +, Luck, Tony wrote: > > If any significant percentage of memory is in ZONE_MOVABLE then the memory > > hotplug people will have to deal with all the lowmem/highmem problems > > that used to be faced by 32-bit x86 with PAE enabled. > > While these problems m

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-30 Thread Glauber Costa
On 11/30/2012 06:58 AM, Luck, Tony wrote: >> If any significant percentage of memory is in ZONE_MOVABLE then the memory >> hotplug people will have to deal with all the lowmem/highmem problems >> that used to be faced by 32-bit x86 with PAE enabled. > > While these problems may still exist on lar

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-30 Thread Lai Jiangshan
On 11/28/2012 12:08 PM, Jiang Liu wrote: > On 2012-11-28 11:24, Bob Liu wrote: >> On Tue, Nov 27, 2012 at 8:49 PM, Tang Chen wrote: >>> On 11/27/2012 08:09 PM, Bob Liu wrote: On Tue, Nov 27, 2012 at 4:29 PM, Tang Chen wrote: > > Hi Liu, > > > This feature is used

RE: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread H. Peter Anvin
Disk I/O is still a big consumer of lowmem. "Luck, Tony" wrote: >> If any significant percentage of memory is in ZONE_MOVABLE then the >memory >> hotplug people will have to deal with all the lowmem/highmem problems >> that used to be faced by 32-bit x86 with PAE enabled. > >While these problem

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Yasuaki Ishimatsu
Hi Jiang, 2012/11/30 11:56, Jiang Liu wrote: Hi Mel, Thanks for your great comments! On 2012-11-29 19:00, Mel Gorman wrote: On Wed, Nov 28, 2012 at 01:38:47PM -0800, H. Peter Anvin wrote: On 11/28/2012 01:34 PM, Luck, Tony wrote: 2. use boot option This is our proposal. New boot

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Jiang Liu
Hi Mel, Thanks for your great comments! On 2012-11-29 19:00, Mel Gorman wrote: > On Wed, Nov 28, 2012 at 01:38:47PM -0800, H. Peter Anvin wrote: >> On 11/28/2012 01:34 PM, Luck, Tony wrote: 2. use boot option This is our proposal. New boot option can specify memory range t

RE: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Luck, Tony
> If any significant percentage of memory is in ZONE_MOVABLE then the memory > hotplug people will have to deal with all the lowmem/highmem problems > that used to be faced by 32-bit x86 with PAE enabled. While these problems may still exist on large systems - I think it becomes harder to constru

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread H. Peter Anvin
On 11/29/2012 02:41 PM, Luck, Tony wrote: >> The other bit is that if you really really want high reliability, memory >> mirroring is the way to go; it is the only way you will be able to >> hotremove memory without having to have a pre-event to migrate the >> memory away from the affected node bef

RE: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Luck, Tony
> The other bit is that if you really really want high reliability, memory > mirroring is the way to go; it is the only way you will be able to > hotremove memory without having to have a pre-event to migrate the > memory away from the affected node before the memory is offlined. Some platforms do

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread H. Peter Anvin
On 11/29/2012 03:00 AM, Mel Gorman wrote: > > I've not been paying a whole pile of attention to this because it's not an > area I'm active in but I agree that configuring ZONE_MOVABLE like > this at boot-time is going to be problematic. As awkward as it is, it > would probably work out better to o

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Jiang Liu
Hi Yasuaki, Forgot to mention that I have no objection to this patchset. I think it's a good start point, but we still need to improve usabilities of memory hotplug by passing platform specific information from BIOS. And mechanism provided by this patchset will/may be used to improve usabil

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Jiang Liu
On 11/29/2012 06:38 PM, Yasuaki Ishimatsu wrote: > Hi Tony, > > 2012/11/29 6:34, Luck, Tony wrote: >>> 1. use firmware information >>>According to ACPI spec 5.0, SRAT table has memory affinity structure >>>and the structure has Hot Pluggable Filed. See "5.2.16.2 Memory >>>Affinity Stru

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Mel Gorman
On Thu, Nov 29, 2012 at 07:38:26PM +0900, Yasuaki Ishimatsu wrote: > Hi Tony, > > 2012/11/29 6:34, Luck, Tony wrote: > >>1. use firmware information > >> According to ACPI spec 5.0, SRAT table has memory affinity structure > >> and the structure has Hot Pluggable Filed. See "5.2.16.2 Memory >

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Mel Gorman
On Wed, Nov 28, 2012 at 01:38:47PM -0800, H. Peter Anvin wrote: > On 11/28/2012 01:34 PM, Luck, Tony wrote: > >> > >> 2. use boot option > >> This is our proposal. New boot option can specify memory range to use > >> as movable memory. > > > > Isn't this just moving the work to the user? To pi

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-29 Thread Yasuaki Ishimatsu
Hi Tony, 2012/11/29 6:34, Luck, Tony wrote: 1. use firmware information According to ACPI spec 5.0, SRAT table has memory affinity structure and the structure has Hot Pluggable Filed. See "5.2.16.2 Memory Affinity Structure". If we use the information, we might be able to specify mov

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-28 Thread Jiang Liu
On 2012-11-29 10:49, Wanpeng Li wrote: > On Thu, Nov 29, 2012 at 10:25:40AM +0800, Jiang Liu wrote: >> On 2012-11-29 9:42, Jaegeuk Hanse wrote: >>> On Wed, Nov 28, 2012 at 04:47:42PM +0800, Jiang Liu wrote: Hi all, Seems it's a great chance to discuss about the memory hotplug feature >

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-28 Thread Jiang Liu
On 2012-11-29 9:42, Jaegeuk Hanse wrote: > On Wed, Nov 28, 2012 at 04:47:42PM +0800, Jiang Liu wrote: >> Hi all, >> Seems it's a great chance to discuss about the memory hotplug feature >> within this thread. So I will try to give some high level thoughts about >> memory >> hotplug feature on

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-28 Thread Jaegeuk Hanse
On Wed, Nov 28, 2012 at 04:47:42PM +0800, Jiang Liu wrote: >Hi all, > Seems it's a great chance to discuss about the memory hotplug feature >within this thread. So I will try to give some high level thoughts about memory >hotplug feature on x86/IA64. Any comments are welcomed! > First o

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-28 Thread Tang Chen
On 11/29/2012 08:43 AM, Jaegeuk Hanse wrote: Hi Tang, I haven't read the patchset yet, but could you give a short describe how you design your implementation in this patchset? Regards, Jaegeuk Hi Jaegeuk, Thanks for your joining in. :) This feature is used in memory hotplug. In order to i

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-28 Thread Jaegeuk Hanse
On Wed, Nov 28, 2012 at 04:29:01PM +0800, Wen Congyang wrote: >At 11/28/2012 12:08 PM, Jiang Liu Wrote: >> On 2012-11-28 11:24, Bob Liu wrote: >>> On Tue, Nov 27, 2012 at 8:49 PM, Tang Chen wrote: On 11/27/2012 08:09 PM, Bob Liu wrote: > > On Tue, Nov 27, 2012 at 4:29 PM, Tang Chen >>

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-28 Thread H. Peter Anvin
On 11/28/2012 01:34 PM, Luck, Tony wrote: >> >> 2. use boot option >> This is our proposal. New boot option can specify memory range to use >> as movable memory. > > Isn't this just moving the work to the user? To pick good values for the > movable areas, they need to know how the memory lines

RE: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-28 Thread Luck, Tony
> 1. use firmware information > According to ACPI spec 5.0, SRAT table has memory affinity structure > and the structure has Hot Pluggable Filed. See "5.2.16.2 Memory > Affinity Structure". If we use the information, we might be able to > specify movable memory by firmware. For example, if

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-28 Thread Jiang Liu
Hi all, Seems it's a great chance to discuss about the memory hotplug feature within this thread. So I will try to give some high level thoughts about memory hotplug feature on x86/IA64. Any comments are welcomed! First of all, I think usability really matters. Ideally, memory hotpl

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-28 Thread Wen Congyang
At 11/28/2012 04:28 PM, Jiang Liu Wrote: > On 2012-11-28 16:29, Wen Congyang wrote: >> At 11/28/2012 12:08 PM, Jiang Liu Wrote: >>> On 2012-11-28 11:24, Bob Liu wrote: On Tue, Nov 27, 2012 at 8:49 PM, Tang Chen wrote: > On 11/27/2012 08:09 PM, Bob Liu wrote: >> >> On Tue, Nov 27,

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-28 Thread Jiang Liu
On 2012-11-28 16:29, Wen Congyang wrote: > At 11/28/2012 12:08 PM, Jiang Liu Wrote: >> On 2012-11-28 11:24, Bob Liu wrote: >>> On Tue, Nov 27, 2012 at 8:49 PM, Tang Chen wrote: On 11/27/2012 08:09 PM, Bob Liu wrote: > > On Tue, Nov 27, 2012 at 4:29 PM, Tang Chen > wrote: >> >>

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-28 Thread Wen Congyang
At 11/28/2012 12:08 PM, Jiang Liu Wrote: > On 2012-11-28 11:24, Bob Liu wrote: >> On Tue, Nov 27, 2012 at 8:49 PM, Tang Chen wrote: >>> On 11/27/2012 08:09 PM, Bob Liu wrote: On Tue, Nov 27, 2012 at 4:29 PM, Tang Chen wrote: > > Hi Liu, > > > This feature is used

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Jiang Liu
Hi Chen, If a pageblock's migration type is movable, it may be converted to reclaimable under memory pressure. CMA is introduced to guarantee that pages of CMA won't be converted to other migratetypes. And we are trying to avoid allocating kernel/DMA memory from specific memory ranges, so we coul

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Tang Chen
Hi Bob, Liu Jiang, About CMA, could you give me more info ? Thanks for your patent and nice advice. :) 1) I saw the following on http://lwn.net/Articles/447405/: The "CMA" type is sticky; pages which are marked as being for CMA should never have their migration type changed by the kernel. As

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Jiang Liu
On 2012-11-28 13:21, Wen Congyang wrote: > At 11/28/2012 12:01 PM, Jiang Liu Wrote: >> On 2012-11-28 11:47, Tang Chen wrote: >>> On 11/27/2012 11:10 AM, wujianguo wrote: Hi Tang, DMA address can't be set as movable, if some one boot kernel with movablecore_map=4G@0xa0 or

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Wen Congyang
At 11/28/2012 12:01 PM, Jiang Liu Wrote: > On 2012-11-28 11:47, Tang Chen wrote: >> On 11/27/2012 11:10 AM, wujianguo wrote: >>> >>> Hi Tang, >>> DMA address can't be set as movable, if some one boot kernel with >>> movablecore_map=4G@0xa0 or other memory region that contains DMA >>> addre

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Jianguo Wu
On 2012/11/28 11:47, Tang Chen wrote: > On 11/27/2012 11:10 AM, wujianguo wrote: >> >> Hi Tang, >> DMA address can't be set as movable, if some one boot kernel with >> movablecore_map=4G@0xa0 or other memory region that contains DMA address, >> system maybe boot failed. Should this case be

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Jiang Liu
On 2012-11-28 11:24, Bob Liu wrote: > On Tue, Nov 27, 2012 at 8:49 PM, Tang Chen wrote: >> On 11/27/2012 08:09 PM, Bob Liu wrote: >>> >>> On Tue, Nov 27, 2012 at 4:29 PM, Tang Chen >>> wrote: Hi Liu, This feature is used in memory hotplug. In order to implement a

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Jiang Liu
On 2012-11-28 11:47, Tang Chen wrote: > On 11/27/2012 11:10 AM, wujianguo wrote: >> >> Hi Tang, >> DMA address can't be set as movable, if some one boot kernel with >> movablecore_map=4G@0xa0 or other memory region that contains DMA address, >> system maybe boot failed. Should this case be

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Tang Chen
On 11/27/2012 11:10 AM, wujianguo wrote: Hi Tang, DMA address can't be set as movable, if some one boot kernel with movablecore_map=4G@0xa0 or other memory region that contains DMA address, system maybe boot failed. Should this case be handled or mentioned in the change log and kerne

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Bob Liu
On Tue, Nov 27, 2012 at 8:49 PM, Tang Chen wrote: > On 11/27/2012 08:09 PM, Bob Liu wrote: >> >> On Tue, Nov 27, 2012 at 4:29 PM, Tang Chen >> wrote: >>> >>> Hi Liu, >>> >>> >>> This feature is used in memory hotplug. >>> >>> In order to implement a whole node hotplug, we need to make sure the >>>

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Tang Chen
On 11/27/2012 08:09 PM, Bob Liu wrote: On Tue, Nov 27, 2012 at 4:29 PM, Tang Chen wrote: Hi Liu, This feature is used in memory hotplug. In order to implement a whole node hotplug, we need to make sure the node contains no kernel memory, because memory used by kernel could not be migrated. (S

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Bob Liu
On Tue, Nov 27, 2012 at 4:29 PM, Tang Chen wrote: > On 11/27/2012 04:00 PM, Bob Liu wrote: >> >> Hi Tang, >> >> On Fri, Nov 23, 2012 at 6:44 PM, Tang Chen >> wrote: >>> >>> [What we are doing] >>> This patchset provide a boot option for user to specify ZONE_MOVABLE >>> memory >>> map for each node

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Yasuaki Ishimatsu
Hi HPA and Tang, 2012/11/27 17:49, H. Peter Anvin wrote: On 11/27/2012 12:29 AM, Tang Chen wrote: Another approach is like the following: movable_node = 1,3-5,8 This could set all the memory on the nodes to be movable. And the rest of memory works as usual. But movablecore_map is more flexible.

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread H. Peter Anvin
On 11/27/2012 01:47 AM, Wen Congyang wrote: At 11/27/2012 04:49 PM, H. Peter Anvin Wrote: On 11/27/2012 12:29 AM, Tang Chen wrote: Another approach is like the following: movable_node = 1,3-5,8 This could set all the memory on the nodes to be movable. And the rest of memory works as usual. But

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Wen Congyang
At 11/27/2012 04:49 PM, H. Peter Anvin Wrote: > On 11/27/2012 12:29 AM, Tang Chen wrote: >> Another approach is like the following: >> movable_node = 1,3-5,8 >> This could set all the memory on the nodes to be movable. And the rest >> of memory works as usual. But movablecore_map is more flexible.

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread H. Peter Anvin
On 11/27/2012 12:29 AM, Tang Chen wrote: > Another approach is like the following: > movable_node = 1,3-5,8 > This could set all the memory on the nodes to be movable. And the rest > of memory works as usual. But movablecore_map is more flexible. ... but *much* harder for users, so movable_node is

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Tang Chen
On 11/27/2012 04:00 PM, Bob Liu wrote: Hi Tang, On Fri, Nov 23, 2012 at 6:44 PM, Tang Chen wrote: [What we are doing] This patchset provide a boot option for user to specify ZONE_MOVABLE memory map for each node in the system. movablecore_map=nn[KMG]@ss[KMG] This option make sure memory rang

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-27 Thread Bob Liu
Hi Tang, On Fri, Nov 23, 2012 at 6:44 PM, Tang Chen wrote: > [What we are doing] > This patchset provide a boot option for user to specify ZONE_MOVABLE memory > map for each node in the system. > > movablecore_map=nn[KMG]@ss[KMG] > > This option make sure memory range from ss to ss+nn is movable

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-26 Thread Jianguo Wu
On 2012/11/27 13:43, Tang Chen wrote: > On 11/27/2012 11:10 AM, wujianguo wrote: >> On 2012-11-23 18:44, Tang Chen wrote: >>> [What we are doing] >>> This patchset provide a boot option for user to specify ZONE_MOVABLE memory >>> map for each node in the system. >>> >>> movablecore_map=nn[KMG]@ss[

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-26 Thread H. Peter Anvin
On 11/26/2012 09:43 PM, Tang Chen wrote: And about how to fix it, as you said, we can handle the situation if user specified DMA address as movable. But how to handle "too little memory for kernel to start" case ? Is there any info about how much at least memory kernel needs ? Not really, an

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-26 Thread Tang Chen
On 11/27/2012 11:10 AM, wujianguo wrote: On 2012-11-23 18:44, Tang Chen wrote: [What we are doing] This patchset provide a boot option for user to specify ZONE_MOVABLE memory map for each node in the system. movablecore_map=nn[KMG]@ss[KMG] Hi Tang, DMA address can't be set as movable

Re: [PATCH v2 0/5] Add movablecore_map boot option

2012-11-26 Thread wujianguo
On 2012-11-23 18:44, Tang Chen wrote: > [What we are doing] > This patchset provide a boot option for user to specify ZONE_MOVABLE memory > map for each node in the system. > > movablecore_map=nn[KMG]@ss[KMG] > Hi Tang, DMA address can't be set as movable, if some one boot kernel with mo

[PATCH v2 0/5] Add movablecore_map boot option

2012-11-23 Thread Tang Chen
[What we are doing] This patchset provide a boot option for user to specify ZONE_MOVABLE memory map for each node in the system. movablecore_map=nn[KMG]@ss[KMG] This option make sure memory range from ss to ss+nn is movable memory. [Why we do this] If we hot remove a memroy, the memory cannot h