Re: [PATCH v2 0/5] Add option to mmap GEM buffers cached

2021-03-10 Thread Thomas Zimmermann
Hi Am 10.03.21 um 20:02 schrieb Paul Cercueil: Hi Thomas, Le lun. 8 mars 2021 à 9:41, Thomas Zimmermann a écrit : Hi Paul, having individual functions for each mode only makes sense if the decision is at compile time. But in patch 5, you're working around your earlier design by introducin

Re: [PATCH v2 0/5] Add option to mmap GEM buffers cached

2021-03-10 Thread Paul Cercueil
Hi Thomas, Le lun. 8 mars 2021 à 9:41, Thomas Zimmermann a écrit : Hi Paul, having individual functions for each mode only makes sense if the decision is at compile time. But in patch 5, you're working around your earlier design by introducing in-driver helpers that select the correct CMA

Re: [PATCH v2 0/5] Add option to mmap GEM buffers cached

2021-03-08 Thread Thomas Zimmermann
Hi Paul, having individual functions for each mode only makes sense if the decision is at compile time. But in patch 5, you're working around your earlier design by introducing in-driver helpers that select the correct CMA function. In SHMEM helpers we have the flag map_wc in the GEM structu

[PATCH v2 0/5] Add option to mmap GEM buffers cached

2021-03-07 Thread Paul Cercueil
Rework of my previous patchset which added support for GEM buffers backed by non-coherent memory to the ingenic-drm driver. Having GEM buffers backed by non-coherent memory is interesting in the particular case where it is faster to render to a non-coherent buffer then sync the data cache, than to