Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-08-01 Thread David Hildenbrand
On 01.08.19 09:48, Michal Hocko wrote: > On Thu 01-08-19 09:39:57, Michal Hocko wrote: >> On Thu 01-08-19 09:31:09, David Hildenbrand wrote: >>> On 01.08.19 09:26, David Hildenbrand wrote: >> [...] I am not sure about the implications of having pfn_valid()/pfn_present()/pfn_online()

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-08-01 Thread Michal Hocko
On Thu 01-08-19 09:50:29, David Hildenbrand wrote: > On 01.08.19 09:34, Michal Hocko wrote: > > On Thu 01-08-19 09:26:35, David Hildenbrand wrote: > >> On 01.08.19 09:24, Michal Hocko wrote: > >>> On Thu 01-08-19 09:18:47, David Hildenbrand wrote: > On 01.08.19 09:17, Michal Hocko wrote: >

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-08-01 Thread David Hildenbrand
On 01.08.19 09:34, Michal Hocko wrote: > On Thu 01-08-19 09:26:35, David Hildenbrand wrote: >> On 01.08.19 09:24, Michal Hocko wrote: >>> On Thu 01-08-19 09:18:47, David Hildenbrand wrote: On 01.08.19 09:17, Michal Hocko wrote: > On Thu 01-08-19 09:06:40, Rashmica Gupta wrote: >> On

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-08-01 Thread Michal Hocko
On Thu 01-08-19 09:39:57, Michal Hocko wrote: > On Thu 01-08-19 09:31:09, David Hildenbrand wrote: > > On 01.08.19 09:26, David Hildenbrand wrote: > [...] > > > I am not sure about the implications of having > > > pfn_valid()/pfn_present()/pfn_online() return true but accessing it > > > results in

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-08-01 Thread Michal Hocko
On Thu 01-08-19 09:31:09, David Hildenbrand wrote: > On 01.08.19 09:26, David Hildenbrand wrote: [...] > > I am not sure about the implications of having > > pfn_valid()/pfn_present()/pfn_online() return true but accessing it > > results in crashes. (suspend, kdump, whatever other technology

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-08-01 Thread Michal Hocko
On Thu 01-08-19 09:26:35, David Hildenbrand wrote: > On 01.08.19 09:24, Michal Hocko wrote: > > On Thu 01-08-19 09:18:47, David Hildenbrand wrote: > >> On 01.08.19 09:17, Michal Hocko wrote: > >>> On Thu 01-08-19 09:06:40, Rashmica Gupta wrote: > On Wed, 2019-07-31 at 14:08 +0200, Michal

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-08-01 Thread David Hildenbrand
On 01.08.19 09:26, David Hildenbrand wrote: > On 01.08.19 09:24, Michal Hocko wrote: >> On Thu 01-08-19 09:18:47, David Hildenbrand wrote: >>> On 01.08.19 09:17, Michal Hocko wrote: On Thu 01-08-19 09:06:40, Rashmica Gupta wrote: > On Wed, 2019-07-31 at 14:08 +0200, Michal Hocko wrote:

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-08-01 Thread David Hildenbrand
On 01.08.19 09:24, Michal Hocko wrote: > On Thu 01-08-19 09:18:47, David Hildenbrand wrote: >> On 01.08.19 09:17, Michal Hocko wrote: >>> On Thu 01-08-19 09:06:40, Rashmica Gupta wrote: On Wed, 2019-07-31 at 14:08 +0200, Michal Hocko wrote: > On Tue 02-07-19 18:52:01, Rashmica Gupta

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-08-01 Thread Michal Hocko
On Thu 01-08-19 09:18:47, David Hildenbrand wrote: > On 01.08.19 09:17, Michal Hocko wrote: > > On Thu 01-08-19 09:06:40, Rashmica Gupta wrote: > >> On Wed, 2019-07-31 at 14:08 +0200, Michal Hocko wrote: > >>> On Tue 02-07-19 18:52:01, Rashmica Gupta wrote: > >>> [...] > > 2) Why it was

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-08-01 Thread David Hildenbrand
On 01.08.19 09:17, Michal Hocko wrote: > On Thu 01-08-19 09:06:40, Rashmica Gupta wrote: >> On Wed, 2019-07-31 at 14:08 +0200, Michal Hocko wrote: >>> On Tue 02-07-19 18:52:01, Rashmica Gupta wrote: >>> [...] > 2) Why it was designed, what is the goal of the interface? > 3) When it is

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-08-01 Thread Michal Hocko
On Thu 01-08-19 09:06:40, Rashmica Gupta wrote: > On Wed, 2019-07-31 at 14:08 +0200, Michal Hocko wrote: > > On Tue 02-07-19 18:52:01, Rashmica Gupta wrote: > > [...] > > > > 2) Why it was designed, what is the goal of the interface? > > > > 3) When it is supposed to be used? > > > > > > > > > >

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-31 Thread Rashmica Gupta
On Wed, 2019-07-31 at 14:08 +0200, Michal Hocko wrote: > On Tue 02-07-19 18:52:01, Rashmica Gupta wrote: > [...] > > > 2) Why it was designed, what is the goal of the interface? > > > 3) When it is supposed to be used? > > > > > > > > There is a hardware debugging facility (htm) on some power

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-31 Thread Michal Hocko
On Tue 02-07-19 18:52:01, Rashmica Gupta wrote: [...] > > 2) Why it was designed, what is the goal of the interface? > > 3) When it is supposed to be used? > > > > > There is a hardware debugging facility (htm) on some power chips. To use > this you need a contiguous portion of memory for the

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-31 Thread David Hildenbrand
On 31.07.19 04:21, Rashmica Gupta wrote: > On Mon, 2019-07-29 at 10:06 +0200, David Hildenbrand wrote: Of course, other interfaces might make sense. You can then start using these memory blocks and hinder them from getting onlined (as a safety net) via memory notifiers.

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-30 Thread Rashmica Gupta
On Mon, 2019-07-29 at 10:06 +0200, David Hildenbrand wrote: > > > Of course, other interfaces might make sense. > > > > > > You can then start using these memory blocks and hinder them from > > > getting onlined (as a safety net) via memory notifiers. > > > > > > That would at least avoid you

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-30 Thread Rashmica Gupta
On Mon, 2019-07-29 at 10:06 +0200, David Hildenbrand wrote: > > > Of course, other interfaces might make sense. > > > > > > You can then start using these memory blocks and hinder them from > > > getting onlined (as a safety net) via memory notifiers. > > > > > > That would at least avoid you

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-29 Thread David Hildenbrand
>> Of course, other interfaces might make sense. >> >> You can then start using these memory blocks and hinder them from >> getting onlined (as a safety net) via memory notifiers. >> >> That would at least avoid you having to call >> add_memory/remove_memory/offline_pages/device_online/modifying

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-28 Thread Rashmica Gupta
On Tue, 2019-07-16 at 14:28 +0200, David Hildenbrand wrote: > On 02.07.19 08:42, Rashmica Gupta wrote: > > Hi David, > > > > Sorry for the late reply. > > Hi, > > sorry I was on PTO :) > > > On Wed, 2019-06-26 at 10:28 +0200, David Hildenbrand wrote: > > > On 26.06.19 10:15, Oscar Salvador

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-16 Thread David Hildenbrand
On 02.07.19 08:42, Rashmica Gupta wrote: > Hi David, > > Sorry for the late reply. Hi, sorry I was on PTO :) > > On Wed, 2019-06-26 at 10:28 +0200, David Hildenbrand wrote: >> On 26.06.19 10:15, Oscar Salvador wrote: >>> On Wed, Jun 26, 2019 at 10:11:06AM +0200, David Hildenbrand wrote:

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-09 Thread Rashmica Gupta
Woops, looks like my phone doesn't send plain text emails :/ On Tue, Jul 2, 2019 at 6:52 PM Rashmica Gupta wrote: > > On Tue, Jul 2, 2019 at 5:48 PM Oscar Salvador wrote: >> >> On Tue, Jul 02, 2019 at 04:42:34PM +1000, Rashmica Gupta wrote: >> > Hi David, >> > >> > Sorry for the late reply. >>

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-02 Thread Oscar Salvador
On Tue, Jul 02, 2019 at 04:42:34PM +1000, Rashmica Gupta wrote: > Hi David, > > Sorry for the late reply. > > On Wed, 2019-06-26 at 10:28 +0200, David Hildenbrand wrote: > > On 26.06.19 10:15, Oscar Salvador wrote: > > > On Wed, Jun 26, 2019 at 10:11:06AM +0200, David Hildenbrand wrote: > > > >

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-07-02 Thread Rashmica Gupta
Hi David, Sorry for the late reply. On Wed, 2019-06-26 at 10:28 +0200, David Hildenbrand wrote: > On 26.06.19 10:15, Oscar Salvador wrote: > > On Wed, Jun 26, 2019 at 10:11:06AM +0200, David Hildenbrand wrote: > > > Back then, I already mentioned that we might have some users that > > >

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-06-26 Thread David Hildenbrand
On 26.06.19 10:27, Oscar Salvador wrote: > On Wed, Jun 26, 2019 at 10:15:16AM +0200, Oscar Salvador wrote: >> On Wed, Jun 26, 2019 at 10:11:06AM +0200, David Hildenbrand wrote: >>> Back then, I already mentioned that we might have some users that >>> remove_memory() they never added in a

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-06-26 Thread David Hildenbrand
On 26.06.19 10:15, Oscar Salvador wrote: > On Wed, Jun 26, 2019 at 10:11:06AM +0200, David Hildenbrand wrote: >> Back then, I already mentioned that we might have some users that >> remove_memory() they never added in a granularity it wasn't added. My >> concerns back then were never fully sorted

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-06-26 Thread Oscar Salvador
On Wed, Jun 26, 2019 at 10:15:16AM +0200, Oscar Salvador wrote: > On Wed, Jun 26, 2019 at 10:11:06AM +0200, David Hildenbrand wrote: > > Back then, I already mentioned that we might have some users that > > remove_memory() they never added in a granularity it wasn't added. My > > concerns back

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-06-26 Thread Oscar Salvador
On Wed, Jun 26, 2019 at 10:11:06AM +0200, David Hildenbrand wrote: > Back then, I already mentioned that we might have some users that > remove_memory() they never added in a granularity it wasn't added. My > concerns back then were never fully sorted out. > >

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-06-26 Thread David Hildenbrand
On 26.06.19 10:03, Oscar Salvador wrote: > On Tue, Jun 25, 2019 at 10:25:48AM +0200, David Hildenbrand wrote: >>> [Coverletter] >>> >>> This is another step to make memory hotplug more usable. The primary >>> goal of this patchset is to reduce memory overhead of the hot-added >>> memory (at least

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-06-26 Thread Oscar Salvador
On Tue, Jun 25, 2019 at 10:25:48AM +0200, David Hildenbrand wrote: > > [Coverletter] > > > > This is another step to make memory hotplug more usable. The primary > > goal of this patchset is to reduce memory overhead of the hot-added > > memory (at least for SPARSEMEM_VMEMMAP memory model). The

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-06-25 Thread David Hildenbrand
On 25.06.19 10:25, David Hildenbrand wrote: > On 25.06.19 09:52, Oscar Salvador wrote: >> Hi, >> >> It has been while since I sent previous version [1]. >> >> In this version I added some feedback I got back then, like letting >> the caller decide whether he wants allocating per memory block or >>

Re: [PATCH v2 0/5] Allocate memmap from hotadded memory

2019-06-25 Thread David Hildenbrand
On 25.06.19 09:52, Oscar Salvador wrote: > Hi, > > It has been while since I sent previous version [1]. > > In this version I added some feedback I got back then, like letting > the caller decide whether he wants allocating per memory block or > per memory range (patch#2), and having the chance

[PATCH v2 0/5] Allocate memmap from hotadded memory

2019-06-25 Thread Oscar Salvador
Hi, It has been while since I sent previous version [1]. In this version I added some feedback I got back then, like letting the caller decide whether he wants allocating per memory block or per memory range (patch#2), and having the chance to disable vmemmap when users want to expose all