Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-16 Thread Jacek Anaszewski
Hi Michał, On 02/16/2017 12:32 PM, Michał Kępień wrote: >> The led stops working after 4th patch "platform/x86: dell-laptop: >> import dell_micmute_led_set() from drivers/leds/dell-led.c", and the >> .config is with CONFIG_DELL_LAPTOP=m >> >> However, I found dell-laptop is not loaded on Latitude

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-16 Thread Andy Shevchenko
On Thu, Feb 16, 2017 at 2:01 PM, Michał Kępień wrote: >> On Thu, Feb 16, 2017 at 1:32 PM, Michał Kępień wrote: >> >> > For maintainers' convenience, I am planning to submit a v3 with all the >> > tags supplied by everyone who reviewed this series and also some minor >> > coding style tweaks sugge

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-16 Thread Michał Kępień
> On Thu, Feb 16, 2017 at 1:32 PM, Michał Kępień wrote: > > > For maintainers' convenience, I am planning to submit a v3 with all the > > tags supplied by everyone who reviewed this series and also some minor > > coding style tweaks suggested along the way. > > Thanks! > I'm a bit busy right now

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-16 Thread Andy Shevchenko
On Thu, Feb 16, 2017 at 1:32 PM, Michał Kępień wrote: > For maintainers' convenience, I am planning to submit a v3 with all the > tags supplied by everyone who reviewed this series and also some minor > coding style tweaks suggested along the way. Thanks! I'm a bit busy right now, but I definite

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-16 Thread Alex Hung
On Thu, Feb 16, 2017 at 7:32 PM, Michał Kępień wrote: >> The led stops working after 4th patch "platform/x86: dell-laptop: >> import dell_micmute_led_set() from drivers/leds/dell-led.c", and the >> .config is with CONFIG_DELL_LAPTOP=m >> >> However, I found dell-laptop is not loaded on Latitude 74

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-16 Thread Michał Kępień
> The led stops working after 4th patch "platform/x86: dell-laptop: > import dell_micmute_led_set() from drivers/leds/dell-led.c", and the > .config is with CONFIG_DELL_LAPTOP=m > > However, I found dell-laptop is not loaded on Latitude 7480 as its > chassis type is Notebook (10), instead of 8 (Po

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-16 Thread Alex Hung
On Thu, Feb 16, 2017 at 5:27 PM, Michał Kępień wrote: >> On Wed, Feb 15, 2017 at 9:54 PM, Michał Kępień wrote: >> > Alex, >> > >> >> I tested the patches with the following setup. Please note I tested >> >> the microphone mute led by GUI, as the hotkey does not work on this >> >> system. >> > >>

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-16 Thread Michał Kępień
> > >> 6. Compiled and installed Linux kernel 4.10 rc8 > > >> > > >> -> Microphone mute led does not work > > > > > > This is even more confusing. Between 4.9, which you claim works fine, > > > and 4.10-rc8, which you claim does not work, I can see no changes to > > > either drivers/leds/dell-le

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-16 Thread Michał Kępień
> On Wed, Feb 15, 2017 at 9:54 PM, Michał Kępień wrote: > > Alex, > > > >> I tested the patches with the following setup. Please note I tested > >> the microphone mute led by GUI, as the hotkey does not work on this > >> system. > > > > Thank you for taking the time to test this series, it is appr

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-15 Thread Takashi Iwai
On Mon, 13 Feb 2017 12:26:40 +0100, Michał Kępień wrote: > > Hi everyone, > > It has been almost a month since I posted v2, so I hope sending a > reminder is okay. > > Jaroslav, Takashi, could you please ack this patch series from the sound > subsystem perspective? Patches 2-4 touch it. Sorry

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-15 Thread Pali Rohár
On Wednesday 15 February 2017 22:31:39 Alex Hung wrote: > On Wed, Feb 15, 2017 at 9:54 PM, Michał Kępień wrote: > > Alex, > > > >> I tested the patches with the following setup. Please note I tested > >> the microphone mute led by GUI, as the hotkey does not work on this > >> system. > > > > Thank

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-15 Thread Alex Hung
On Wed, Feb 15, 2017 at 9:54 PM, Michał Kępień wrote: > Alex, > >> I tested the patches with the following setup. Please note I tested >> the microphone mute led by GUI, as the hotkey does not work on this >> system. > > Thank you for taking the time to test this series, it is appreciated. I > wo

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-15 Thread Michał Kępień
Alex, > I tested the patches with the following setup. Please note I tested > the microphone mute led by GUI, as the hotkey does not work on this > system. Thank you for taking the time to test this series, it is appreciated. I would not expect the switching method (GUI/hotkey) to matter here,

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-15 Thread Alex Hung
Hi, I tested the patches with the following setup. Please note I tested the microphone mute led by GUI, as the hotkey does not work on this system. 1. Downloaded the below patches from patchwork 9518737 Awaiting Upstream [v2,1/6] dell-led: remove GUID check from dell_micmute_led_set() 9518761 Aw

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-02-13 Thread Michał Kępień
Hi everyone, It has been almost a month since I posted v2, so I hope sending a reminder is okay. Jaroslav, Takashi, could you please ack this patch series from the sound subsystem perspective? Patches 2-4 touch it. Anthony, have you and your team perhaps had a chance to test this patch series o

Re: [PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-01-17 Thread Jacek Anaszewski
Hi Darren, Are you OK with the patches 4/6 and 6/6? If so, could you give your ack so that I could apply the whole patch set to the LED tree? Best regards, Jacek Anaszewski On 01/16/2017 02:21 PM, Michał Kępień wrote: > This patch series moves the dell-led driver from the LED subsystem to > the

[PATCH v2 0/6] Move dell-led to drivers/platform/x86

2017-01-16 Thread Michał Kępień
This patch series moves the dell-led driver from the LED subsystem to the x86 platform driver subsystem. The original motivation behind this effort was to move all code using the dell-smbios module to the x86 platform driver subsystem. While I was investigating the possibilities to do that, it qu