Re: [PATCH v2 0/6] tracing: open/delete fixes

2013-07-29 Thread Oleg Nesterov
On 07/29, Masami Hiramatsu wrote: > > (2013/07/27 2:25), Oleg Nesterov wrote: > > > > Masami, I'll appreciate your review ;) > > I think this is OK Great, thanks. > except for the bisecting issue, as I pointed in > reply to 6/6. ;) Perhaps, but so far the problem is not clear to me. Anyway, if

Re: [PATCH v2 0/6] tracing: open/delete fixes

2013-07-29 Thread Masami Hiramatsu
(2013/07/27 2:25), Oleg Nesterov wrote: > Hello. > > Testing: seems to work, but assumes that debugs was fixed too. Hopefully > "debugfs: debugfs_remove_recursive() must not rely on list_empty(d_subdirs)" > is fine. > > (We should probably make debugfs_remove_recursive() to return the error > an

Re: [PATCH v2 0/6] tracing: open/delete fixes

2013-07-28 Thread Oleg Nesterov
On 07/26, Oleg Nesterov wrote: > > Testing: seems to work, but assumes that debugs was fixed too. Hopefully > "debugfs: debugfs_remove_recursive() must not rely on list_empty(d_subdirs)" > is fine. > > (We should probably make debugfs_remove_recursive() to return the error > and trace_events.c sho

[PATCH v2 0/6] tracing: open/delete fixes

2013-07-26 Thread Oleg Nesterov
Hello. Testing: seems to work, but assumes that debugs was fixed too. Hopefully "debugfs: debugfs_remove_recursive() must not rely on list_empty(d_subdirs)" is fine. (We should probably make debugfs_remove_recursive() to return the error and trace_events.c should warn if it fails) However: I am