Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-07 Thread Greg Kroah-Hartman
On Mon, Dec 07, 2020 at 09:49:03AM +0100, Hans de Goede wrote: > Note if in the future you do see benefit in switching the auxiliary bus > I have no problems with that. But atm I don't really see any benefits of > doing so, so then we would just be switching over for the sake of switching > over

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-07 Thread Hans de Goede
Hi, On 12/6/20 4:58 PM, Maximilian Luz wrote: > On 12/6/20 8:07 AM, Leon Romanovsky wrote: >> On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: >>> Hello, >>> >>> Here is version two of the Surface System Aggregator Module (SAM/SSAM) >>> driver series, adding initial support for the

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 04:58:52PM +0100, Maximilian Luz wrote: > On 12/6/20 8:07 AM, Leon Romanovsky wrote: > > On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: > > > Hello, > > > > > > Here is version two of the Surface System Aggregator Module (SAM/SSAM) > > > driver series,

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Maximilian Luz
On 12/6/20 8:07 AM, Leon Romanovsky wrote: On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: Hello, Here is version two of the Surface System Aggregator Module (SAM/SSAM) driver series, adding initial support for the embedded controller on 5th and later generation Microsoft

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Maximilian Luz
On 12/6/20 12:41 PM, Leon Romanovsky wrote: On Sun, Dec 06, 2020 at 11:41:46AM +0100, Hans de Goede wrote: Hi, On 12/6/20 11:33 AM, Leon Romanovsky wrote: On Sun, Dec 06, 2020 at 11:04:06AM +0100, Hans de Goede wrote: But there is a difference between being careful and just nacking it

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Maximilian Luz
On 12/6/20 12:30 PM, Leon Romanovsky wrote: On Sun, Dec 06, 2020 at 11:33:40AM +0100, Maximilian Luz wrote: On 12/6/20 10:06 AM, Leon Romanovsky wrote:> On Sun, Dec 06, 2020 at 05:58:32PM +0900, Blaž Hrastnik wrote: More on that, the whole purpose of proposed interface is to debug and

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 11:41:46AM +0100, Hans de Goede wrote: > Hi, > > On 12/6/20 11:33 AM, Leon Romanovsky wrote: > > On Sun, Dec 06, 2020 at 11:04:06AM +0100, Hans de Goede wrote: > > > > >> But there is a difference between being careful and just nacking > >> it because no new UAPI may be

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 11:33:40AM +0100, Maximilian Luz wrote: > On 12/6/20 10:06 AM, Leon Romanovsky wrote:> On Sun, Dec 06, 2020 at > 05:58:32PM +0900, Blaž Hrastnik wrote: > > > > > > > > > More on that, the whole purpose of proposed interface is to debug and > > > > > not intended to be used

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Maximilian Luz
On 12/6/20 9:32 AM, Greg Kroah-Hartman wrote: On Sun, Dec 06, 2020 at 09:07:05AM +0200, Leon Romanovsky wrote: On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: Hello, Here is version two of the Surface System Aggregator Module (SAM/SSAM) driver series, adding initial support

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Maximilian Luz
On 12/6/20 11:43 AM, Hans de Goede wrote: Hi, On 12/6/20 11:33 AM, Maximilian Luz wrote: On 12/6/20 10:06 AM, Leon Romanovsky wrote:> On Sun, Dec 06, 2020 at 05:58:32PM +0900, Blaž Hrastnik wrote: More on that, the whole purpose of proposed interface is to debug and not intended to be used

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Maximilian Luz
On 12/6/20 11:04 AM, Hans de Goede wrote: Hi, On 12/6/20 9:56 AM, Leon Romanovsky wrote: On Sun, Dec 06, 2020 at 09:41:21AM +0100, Hans de Goede wrote: Hi Leon, On 12/6/20 8:07 AM, Leon Romanovsky wrote: On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: Hello, Here is

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Hans de Goede
Hi, On 12/6/20 11:33 AM, Leon Romanovsky wrote: > On Sun, Dec 06, 2020 at 11:04:06AM +0100, Hans de Goede wrote: >> But there is a difference between being careful and just nacking >> it because no new UAPI may be added at all (also see GKH's response). > > I saw, the author misunderstood the

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Hans de Goede
Hi, On 12/6/20 11:33 AM, Maximilian Luz wrote: > On 12/6/20 10:06 AM, Leon Romanovsky wrote:> On Sun, Dec 06, 2020 at > 05:58:32PM +0900, Blaž Hrastnik wrote: > More on that, the whole purpose of proposed interface is to debug and > not intended to be used by any user space code.

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 11:04:06AM +0100, Hans de Goede wrote: > Hi, > > On 12/6/20 9:56 AM, Leon Romanovsky wrote: > > On Sun, Dec 06, 2020 at 09:41:21AM +0100, Hans de Goede wrote: > >> Hi Leon, > >> > >> On 12/6/20 8:07 AM, Leon Romanovsky wrote: > >>> On Thu, Dec 03, 2020 at 10:26:31PM +0100,

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Maximilian Luz
On 12/6/20 10:06 AM, Leon Romanovsky wrote:> On Sun, Dec 06, 2020 at 05:58:32PM +0900, Blaž Hrastnik wrote: More on that, the whole purpose of proposed interface is to debug and not intended to be used by any user space code. The purpose is to provide raw access to the Surface Serial Hub

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Hans de Goede
Hi, On 12/6/20 9:56 AM, Leon Romanovsky wrote: > On Sun, Dec 06, 2020 at 09:41:21AM +0100, Hans de Goede wrote: >> Hi Leon, >> >> On 12/6/20 8:07 AM, Leon Romanovsky wrote: >>> On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: Hello, Here is version two of the Surface

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 05:58:32PM +0900, Blaž Hrastnik wrote: > > > > > More on that, the whole purpose of proposed interface is to debug and > > > not intended to be used by any user space code. > > > > The purpose is to provide raw access to the Surface Serial Hub protocol, > > just like we

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Blaž Hrastnik
> > > More on that, the whole purpose of proposed interface is to debug and > > not intended to be used by any user space code. > > The purpose is to provide raw access to the Surface Serial Hub protocol, > just like we provide raw access to USB devices and have hidraw devices. > > So this goes

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 09:41:21AM +0100, Hans de Goede wrote: > Hi Leon, > > On 12/6/20 8:07 AM, Leon Romanovsky wrote: > > On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: > >> Hello, > >> > >> Here is version two of the Surface System Aggregator Module (SAM/SSAM) > >> driver

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Hans de Goede
Hi Leon, On 12/6/20 8:07 AM, Leon Romanovsky wrote: > On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: >> Hello, >> >> Here is version two of the Surface System Aggregator Module (SAM/SSAM) >> driver series, adding initial support for the embedded controller on 5th >> and later

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Leon Romanovsky
On Sun, Dec 06, 2020 at 09:32:30AM +0100, Greg Kroah-Hartman wrote: > On Sun, Dec 06, 2020 at 09:07:05AM +0200, Leon Romanovsky wrote: > > On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: > > > Hello, > > > > > > Here is version two of the Surface System Aggregator Module (SAM/SSAM)

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-06 Thread Greg Kroah-Hartman
On Sun, Dec 06, 2020 at 09:07:05AM +0200, Leon Romanovsky wrote: > On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: > > Hello, > > > > Here is version two of the Surface System Aggregator Module (SAM/SSAM) > > driver series, adding initial support for the embedded controller on 5th

Re: [PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-05 Thread Leon Romanovsky
On Thu, Dec 03, 2020 at 10:26:31PM +0100, Maximilian Luz wrote: > Hello, > > Here is version two of the Surface System Aggregator Module (SAM/SSAM) > driver series, adding initial support for the embedded controller on 5th > and later generation Microsoft Surface devices. Initial support includes

[PATCH v2 0/9] Add support for Microsoft Surface System Aggregator Module

2020-12-03 Thread Maximilian Luz
Hello, Here is version two of the Surface System Aggregator Module (SAM/SSAM) driver series, adding initial support for the embedded controller on 5th and later generation Microsoft Surface devices. Initial support includes the ACPI interface to the controller, via which battery and thermal