Re: [PATCH v2 0/9] Extended H/W error log driver

2013-10-17 Thread Borislav Petkov
On Thu, Oct 17, 2013 at 11:25:41AM -0400, Steven Rostedt wrote: > On Thu, 17 Oct 2013 10:33:48 -0400 > Chen Gong wrote: > > > > > Gong, can you try moving the CREATE_TRACE_POINTS line to a new file - > > > arch/x86/ras/ras.c and define it there and not anywhere else, i.e. move > > > it away from

Re: [PATCH v2 0/9] Extended H/W error log driver

2013-10-17 Thread Steven Rostedt
On Thu, 17 Oct 2013 10:33:48 -0400 Chen Gong wrote: > > Gong, can you try moving the CREATE_TRACE_POINTS line to a new file - > > arch/x86/ras/ras.c and define it there and not anywhere else, i.e. move > > it away from edac_mc.c. Does that help? > > In current kernel we haven't arch/x86/ras/ras

Re: [PATCH v2 0/9] Extended H/W error log driver

2013-10-17 Thread Chen Gong
, linux-a...@vger.kernel.org, > linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 0/9] Extended H/W error log driver > User-Agent: Mutt/1.5.21 (2010-09-15) > > On Wed, Oct 16, 2013 at 08:00:38PM +0200, Borislav Petkov wrote: > > Right, the only difference I can see is th

Re: [PATCH v2 0/9] Extended H/W error log driver

2013-10-16 Thread Borislav Petkov
On Wed, Oct 16, 2013 at 08:00:38PM +0200, Borislav Petkov wrote: > Right, the only difference I can see is that include/ras/ras_event.h > doesn't have those below: > > #undef TRACE_INCLUDE_PATH > #undef TRACE_INCLUDE_FILE > #define TRACE_INCLUDE_PATH . > > Perhaps that is the problem? > > Gong,

Re: [PATCH v2 0/9] Extended H/W error log driver

2013-10-16 Thread Borislav Petkov
On Wed, Oct 16, 2013 at 12:56:46PM -0400, Steven Rostedt wrote: > On Wed, 16 Oct 2013 18:05:50 +0200 > Borislav Petkov wrote: > > > > > For trace output format we still need further discussion. In the last > > > patch(support trace interface) I have to reserve previous Kconfig > > > format beca

Re: [PATCH v2 0/9] Extended H/W error log driver

2013-10-16 Thread Steven Rostedt
On Wed, 16 Oct 2013 18:05:50 +0200 Borislav Petkov wrote: > > For trace output format we still need further discussion. In the last > > patch(support trace interface) I have to reserve previous Kconfig > > format because I find once I put trace_event interface in the module, > > it will not wor

Re: [PATCH v2 0/9] Extended H/W error log driver

2013-10-16 Thread Joe Perches
On Wed, 2013-10-16 at 18:05 +0200, Borislav Petkov wrote: > On Wed, Oct 16, 2013 at 10:55:57AM -0400, Chen, Gong wrote: [] > > After applying this patch series, when a memory corrected error happens, > > we can get following information: > > > > dmesg output: > > > > [ 949.545817] {1}Hardware er

Re: [PATCH v2 0/9] Extended H/W error log driver

2013-10-16 Thread Borislav Petkov
On Wed, Oct 16, 2013 at 10:55:57AM -0400, Chen, Gong wrote: > [PATCH v2 1/9] ACPI, APEI, CPER: Fix status check during error printing > [PATCH v2 2/9] ACPI, CPER: Update cper info > [PATCH v2 3/9] bitops: Introduce a more generic BITMASK macro > [PATCH v2 4/9] ACPI, x86: Extended error log driver f

Re: [PATCH v2 0/9] Extended H/W error log driver

2013-10-16 Thread Chen Gong
[...] > > dmesg output format has been updated based on the suggestion from Boris. > For trace output format we still need further discussion. In the last > patch(support trace interface) I have to reserve previous Kconfig format > because I find once I put trace_event interface in the module, it

[PATCH v2 0/9] Extended H/W error log driver

2013-10-16 Thread Chen, Gong
[PATCH v2 1/9] ACPI, APEI, CPER: Fix status check during error printing [PATCH v2 2/9] ACPI, CPER: Update cper info [PATCH v2 3/9] bitops: Introduce a more generic BITMASK macro [PATCH v2 4/9] ACPI, x86: Extended error log driver for x86 platform [PATCH v2 5/9] DMI: Parse memory device (type 17) in