Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-09-04 Thread Viresh Kumar
On 04-09-19, 14:37, Sylwester Nawrocki wrote: > I have changed the code to use dev_pm_opp_adjust_voltage(). I was wondering > though, what did you mean by "triplet" when commenting on this patch > https://patchwork.kernel.org/patch/11092245 ? The voltage value in the OPP core is stored as a

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-09-04 Thread Sylwester Nawrocki
Hi, On 8/20/19 11:21, Viresh Kumar wrote: > On 20-08-19, 11:03, Sylwester Nawrocki wrote: >> On 8/20/19 05:01, Viresh Kumar wrote: >>> Sorry but I am unable to understand the difficulty you are facing now. So >>> what I >>> suggest is something like this. >> >> The difficulty was about

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-08-20 Thread Viresh Kumar
On 20-08-19, 11:03, Sylwester Nawrocki wrote: > On 8/20/19 05:01, Viresh Kumar wrote: > > Sorry but I am unable to understand the difficulty you are facing now. So > > what I > > suggest is something like this. > > The difficulty was about representing data from tables asv_{arm,kfc}_table[][] >

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-08-20 Thread Sylwester Nawrocki
On 8/20/19 05:01, Viresh Kumar wrote: > On 19-08-19, 15:39, Sylwester Nawrocki wrote: >> Unfortunately not, the patch set as I see it is another way of updating >> an OPP after it was parsed from DT. OPP remove/add could work equally >> well in our use case. > > Adding OPPs dynamically has

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-08-19 Thread Viresh Kumar
On 19-08-19, 15:39, Sylwester Nawrocki wrote: > Unfortunately not, the patch set as I see it is another way of updating > an OPP after it was parsed from DT. OPP remove/add could work equally > well in our use case. Adding OPPs dynamically has limitations, you can't set many values which are

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-08-19 Thread Sylwester Nawrocki
On 8/19/19 13:25, Viresh Kumar wrote: > On 19-08-19, 13:16, Sylwester Nawrocki wrote: >> On 8/19/19 11:09, Viresh Kumar wrote: >>> Will something like this help ? >>> >>> https://lore.kernel.org/lkml/1442623929-4507-3-git-send-email-sb...@codeaurora.org/ >>> >>> This never got merged but the idea

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-08-19 Thread Viresh Kumar
On 19-08-19, 13:16, Sylwester Nawrocki wrote: > On 8/19/19 11:09, Viresh Kumar wrote: > > Will something like this help ? > > > > https://lore.kernel.org/lkml/1442623929-4507-3-git-send-email-sb...@codeaurora.org/ > > > > This never got merged but the idea was AVS only. > > It's quite

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-08-19 Thread Sylwester Nawrocki
On 8/19/19 11:09, Viresh Kumar wrote: > Will something like this help ? > > https://lore.kernel.org/lkml/1442623929-4507-3-git-send-email-sb...@codeaurora.org/ > > This never got merged but the idea was AVS only. It's quite interesting work, it seems to be for a more advanced use case where

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-08-19 Thread Viresh Kumar
On 19-08-19, 14:39, Viresh Kumar wrote: > On 09-08-19, 17:58, Sylwester Nawrocki wrote: > > Thank you for your suggestions. > > > > For some Exynos SoC variants the algorithm of selecting CPU voltage supply > > is a bit more complex than just selecting a column in the frequency/voltage > >

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-08-19 Thread Viresh Kumar
On 09-08-19, 17:58, Sylwester Nawrocki wrote: > Thank you for your suggestions. > > For some Exynos SoC variants the algorithm of selecting CPU voltage supply > is a bit more complex than just selecting a column in the frequency/voltage > matrix, i.e. selecting a set of voltage values for whole

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-08-09 Thread Sylwester Nawrocki
Hi Viresh, On 7/25/19 04:23, Viresh Kumar wrote: > On 24-07-19, 15:10, Marek Szyprowski wrote: >> On 2019-07-23 04:04, Viresh Kumar wrote: >>> On 18-07-19, 16:30, Sylwester Nawrocki wrote: This is second iteration of patch series adding ASV (Adaptive Supply Voltage) support for Exynos

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-07-24 Thread Viresh Kumar
On 24-07-19, 15:10, Marek Szyprowski wrote: > Hi Viresh, > > On 2019-07-23 04:04, Viresh Kumar wrote: > > On 18-07-19, 16:30, Sylwester Nawrocki wrote: > >> This is second iteration of patch series adding ASV (Adaptive Supply > >> Voltage) support for Exynos SoCs. The first one can be found at: >

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-07-24 Thread Marek Szyprowski
Hi Viresh, On 2019-07-23 04:04, Viresh Kumar wrote: > On 18-07-19, 16:30, Sylwester Nawrocki wrote: >> This is second iteration of patch series adding ASV (Adaptive Supply >> Voltage) support for Exynos SoCs. The first one can be found at: >>

Re: [PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-07-22 Thread Viresh Kumar
On 18-07-19, 16:30, Sylwester Nawrocki wrote: > This is second iteration of patch series adding ASV (Adaptive Supply > Voltage) support for Exynos SoCs. The first one can be found at: > https://lore.kernel.org/lkml/20190404171735.12815-1-s.nawro...@samsung.com > > The main changes comparing to

[PATCH v2 0/9] Exynos Adaptive Supply Voltage support

2019-07-18 Thread Sylwester Nawrocki
This is second iteration of patch series adding ASV (Adaptive Supply Voltage) support for Exynos SoCs. The first one can be found at: https://lore.kernel.org/lkml/20190404171735.12815-1-s.nawro...@samsung.com The main changes comparing to the first (RFC) version are: - moving ASV data tables