Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-13 Thread Al Viro
On Sat, Dec 13, 2014 at 09:06:45AM -0500, Jeff Layton wrote: > On Fri, 12 Dec 2014 16:59:52 + > Al Viro wrote: > > > On Fri, Dec 12, 2014 at 06:54:08AM -0500, Jeff Layton wrote: > > > > > > Umm... I would be very surprised if it turned out to be a problem. > > > > nfsd really doesn't give a

Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-13 Thread Jeff Layton
On Fri, 12 Dec 2014 16:59:52 + Al Viro wrote: > On Fri, Dec 12, 2014 at 06:54:08AM -0500, Jeff Layton wrote: > > > > Umm... I would be very surprised if it turned out to be a problem. > > > nfsd really doesn't give a fuck about its cwd and root - not in the > > > thread side of things. And

Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-12 Thread Al Viro
On Fri, Dec 12, 2014 at 06:54:08AM -0500, Jeff Layton wrote: > > Umm... I would be very surprised if it turned out to be a problem. > > nfsd really doesn't give a fuck about its cwd and root - not in the > > thread side of things. And (un)exporting is (a) not on a hot path > > and (b) not done f

Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-12 Thread Jeff Layton
On Fri, 12 Dec 2014 03:02:06 + Al Viro wrote: > On Thu, Dec 11, 2014 at 06:29:37PM -0800, Linus Torvalds wrote: > > On Thu, Dec 11, 2014 at 6:12 PM, Al Viro wrote: > > > > > > Linus, do you see any problems with the following patch (against the > > > mainline)? > > > > Not concpetually, bu

Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-11 Thread Al Viro
On Fri, Dec 12, 2014 at 03:02:06AM +, Al Viro wrote: > On Thu, Dec 11, 2014 at 06:29:37PM -0800, Linus Torvalds wrote: > > On Thu, Dec 11, 2014 at 6:12 PM, Al Viro wrote: > > > > > > Linus, do you see any problems with the following patch (against the > > > mainline)? > > > > Not concpetuall

Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-11 Thread Al Viro
On Thu, Dec 11, 2014 at 06:29:37PM -0800, Linus Torvalds wrote: > On Thu, Dec 11, 2014 at 6:12 PM, Al Viro wrote: > > > > Linus, do you see any problems with the following patch (against the > > mainline)? > > Not concpetually, but create_kthread() uses CLONE_FS, and I don't > think it's just um

Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-11 Thread Al Viro
On Fri, Dec 12, 2014 at 02:12:41AM +, Al Viro wrote: > On Wed, Dec 10, 2014 at 02:07:44PM -0500, Jeff Layton wrote: > > > We'll also need Al's ACK on the fs_struct stuff. > > ... and I'm not happy with it. First of all, ditch those EXPORT_SYMBOL_GPL(); > if it's too low-level for general exp

Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-11 Thread Linus Torvalds
On Thu, Dec 11, 2014 at 6:12 PM, Al Viro wrote: > > Linus, do you see any problems with the following patch (against the > mainline)? Not concpetually, but create_kthread() uses CLONE_FS, and I don't think it's just umask that things like nfsd want to avoid sharing. What about all the *other* fi

Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-11 Thread Al Viro
On Wed, Dec 10, 2014 at 02:07:44PM -0500, Jeff Layton wrote: > We'll also need Al's ACK on the fs_struct stuff. ... and I'm not happy with it. First of all, ditch those EXPORT_SYMBOL_GPL(); if it's too low-level for general export (and many of those are), tacking _GPL on it doesn't make it any b

Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-10 Thread Jeff Layton
On Wed, 10 Dec 2014 14:31:55 -0800 Chuck Lever wrote: > Hi Jeff- > > On Dec 10, 2014, at 11:07 AM, Jeff Layton wrote: > > > This is the second revision of the workqueue-based nfsd. Changes from > > the RFC version I posted earlier: > > > > v2: > > - found and fixed problem causing the delays

Re: [PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-10 Thread Chuck Lever
Hi Jeff- On Dec 10, 2014, at 11:07 AM, Jeff Layton wrote: > This is the second revision of the workqueue-based nfsd. Changes from > the RFC version I posted earlier: > > v2: > - found and fixed problem causing the delays between work. It was a bug > in the design of the new code. I was queuein

[PATCH v2 00/16] nfsd/sunrpc: add support for a workqueue-based nfsd

2014-12-10 Thread Jeff Layton
This is the second revision of the workqueue-based nfsd. Changes from the RFC version I posted earlier: v2: - found and fixed problem causing the delays between work. It was a bug in the design of the new code. I was queueing the svc_xprt's work to do everything and that necessarily serialized