Re: [PATCH v2 00/19] scsi: libsas: Remove in_interrupt() check

2021-01-15 Thread Ahmed S. Darwish
On Fri, Jan 15, 2021 at 04:29:51PM +, John Garry wrote: > On 15/01/2021 16:27, Ahmed S. Darwish wrote: > > Thanks! > > > > Shall I add you r-b tag to the whole series then, or only to the ones > > which directly touch libsas (#3, #12, #16, and #19)? > > The whole series, if you like. But there

Re: [PATCH v2 00/19] scsi: libsas: Remove in_interrupt() check

2021-01-15 Thread John Garry
On 15/01/2021 16:27, Ahmed S. Darwish wrote: Thanks! Shall I add you r-b tag to the whole series then, or only to the ones which directly touch libsas (#3, #12, #16, and #19)? The whole series, if you like. But there was a nit about fitting some code on a single line still, and I think Christ

Re: [PATCH v2 00/19] scsi: libsas: Remove in_interrupt() check

2021-01-15 Thread Ahmed S. Darwish
On Thu, Jan 14, 2021 at 09:51:35AM +, John Garry wrote: ... > > To me, the series looks fine. Well, the end result - I didn't go through > patch by patch. So: > > Reviewed-by: John Garry > Thanks! Shall I add you r-b tag to the whole series then, or only to the ones which directly touch libs

Re: [PATCH v2 00/19] scsi: libsas: Remove in_interrupt() check

2021-01-14 Thread John Garry
On 12/01/2021 17:33, Ahmed S. Darwish wrote: On Tue, Jan 12, 2021 at 04:00:57PM +, John Garry wrote: ... I boot-tested on my machines which have hisi_sas v2 and v3 hw, and it's ok. I will ask some guys to test a bit more. Thanks a lot! And generally the changes look ok. But I just have a

Re: [PATCH v2 00/19] scsi: libsas: Remove in_interrupt() check

2021-01-12 Thread Ahmed S. Darwish
On Tue, Jan 12, 2021 at 04:00:57PM +, John Garry wrote: ... > > I boot-tested on my machines which have hisi_sas v2 and v3 hw, and it's ok. > I will ask some guys to test a bit more. > Thanks a lot! > And generally the changes look ok. But I just have a slight concern that we > don't pass the

Re: [PATCH v2 00/19] scsi: libsas: Remove in_interrupt() check

2021-01-12 Thread John Garry
- intel-linux-...@intel.com On 12/01/2021 13:19, Ahmed S. Darwish wrote: On Tue, Jan 12, 2021 at 11:53:50AM +, John Garry wrote: On 12/01/2021 11:06, Ahmed S. Darwish wrote: Hi, Changelog v2 ... I'll give this a spin today and help review also then. I boot-tested on my

Re: [PATCH v2 00/19] scsi: libsas: Remove in_interrupt() check

2021-01-12 Thread Ahmed S. Darwish
On Tue, Jan 12, 2021 at 11:53:50AM +, John Garry wrote: > On 12/01/2021 11:06, Ahmed S. Darwish wrote: > > Hi, > > > > Changelog v2 > > ... > > I'll give this a spin today and help review also then. > > There's 18 patches here - it would be very convenient if they were on a > publi

Re: [PATCH v2 00/19] scsi: libsas: Remove in_interrupt() check

2021-01-12 Thread John Garry
On 12/01/2021 11:06, Ahmed S. Darwish wrote: Hi, Changelog v2 - Rebase on top of v5.11-rc3 - Rebase on top of John's patch "scsi: libsas and users: Remove notifier indirection", as it affects every other patch. Include it in this series (patch #2). - Introduce patches #13 =

[PATCH v2 00/19] scsi: libsas: Remove in_interrupt() check

2021-01-12 Thread Ahmed S. Darwish
Hi, Changelog v2 - Rebase on top of v5.11-rc3 - Rebase on top of John's patch "scsi: libsas and users: Remove notifier indirection", as it affects every other patch. Include it in this series (patch #2). - Introduce patches #13 => #19, which modify call sites back to use the