Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups

2016-07-20 Thread Greg Ungerer
Hi Geert, On 20/07/16 16:54, Geert Uytterhoeven wrote: > Hi Nicolas, > > On Wed, Jul 20, 2016 at 6:09 AM, Nicolas Pitre > wrote: >> On Tue, 19 Jul 2016, Geert Uytterhoeven wrote: >> >>> On Tue, Jul 19, 2016 at 6:52 AM, Greg Ungerer wrote: Seeing as you have modified quite a few printk cal

Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups

2016-07-19 Thread Geert Uytterhoeven
Hi Nicolas, On Wed, Jul 20, 2016 at 6:09 AM, Nicolas Pitre wrote: > On Tue, 19 Jul 2016, Geert Uytterhoeven wrote: > >> On Tue, Jul 19, 2016 at 6:52 AM, Greg Ungerer wrote: >> > Seeing as you have modified quite a few printk calls is it worth >> > while annotating them with appropriate KERN_ERR,

Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups

2016-07-19 Thread Nicolas Pitre
On Tue, 19 Jul 2016, Geert Uytterhoeven wrote: > On Tue, Jul 19, 2016 at 6:52 AM, Greg Ungerer wrote: > > Seeing as you have modified quite a few printk calls is it worth > > while annotating them with appropriate KERN_ERR, KERN_INFO, etc? > > You mean pr_err(), pr_info(), ... ;-) Done. Includ

Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups

2016-07-18 Thread Geert Uytterhoeven
On Tue, Jul 19, 2016 at 6:52 AM, Greg Ungerer wrote: > Seeing as you have modified quite a few printk calls is it worth > while annotating them with appropriate KERN_ERR, KERN_INFO, etc? You mean pr_err(), pr_info(), ... ;-) Gr{oetje,eeting}s, Geert -- Geert Uytterhoeve

Re: [PATCH v2 01/10] binfmt_flat: assorted cleanups

2016-07-18 Thread Greg Ungerer
Hi Nicolas, On 18/07/16 13:31, Nicolas Pitre wrote: > Remove excessive casts, do some code grouping, etc. > No functional changes. > > Signed-off-by: Nicolas Pitre > --- > fs/binfmt_flat.c | 118 > ++- > 1 file changed, 56 insertions(+), 62 d

[PATCH v2 01/10] binfmt_flat: assorted cleanups

2016-07-17 Thread Nicolas Pitre
Remove excessive casts, do some code grouping, etc. No functional changes. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 118 ++- 1 file changed, 56 insertions(+), 62 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index ca