Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-15 Thread Rob Herring
On Thu, 10 Sep 2020 19:57:19 +0200, Krzysztof Kozlowski wrote: > Convert the NXP PCA953x family of GPIO expanders bindings to device tree > schema. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Use additionalProperties. > 2. Add wakeup-source. > 3. Add hogs. > 4. Ext

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-15 Thread Rob Herring
On Sat, Sep 12, 2020 at 12:07:59PM +0200, Linus Walleij wrote: > On Fri, Sep 11, 2020 at 11:54 AM Grygorii Strashko > wrote: > > > More over, there is already generic schema for gpio hogs: gpio-hog.yaml > > Where is this? I don't have it in my GPIO devel branch for sure, and > it is not in linux

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-15 Thread Rob Herring
On Thu, Sep 10, 2020 at 02:13:05PM -0500, Nishanth Menon wrote: > On 20:53-20200910, Krzysztof Kozlowski wrote: > > On Thu, 10 Sep 2020 at 20:28, Nishanth Menon wrote: > > > > > > On 19:57-20200910, Krzysztof Kozlowski wrote: > > > [...] > > > > + wakeup-source: > > > > +$ref: /schemas/types.

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-14 Thread Grygorii Strashko
On 12/09/2020 13:07, Linus Walleij wrote: On Fri, Sep 11, 2020 at 11:54 AM Grygorii Strashko wrote: More over, there is already generic schema for gpio hogs: gpio-hog.yaml Where is this? I don't have it in my GPIO devel branch for sure, and it is not in linux-next either so not in Bartosz

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-12 Thread Linus Walleij
On Fri, Sep 11, 2020 at 11:54 AM Grygorii Strashko wrote: > More over, there is already generic schema for gpio hogs: gpio-hog.yaml Where is this? I don't have it in my GPIO devel branch for sure, and it is not in linux-next either so not in Bartosz' tree. I did suggest that I want a gpio-commo

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-11 Thread Grygorii Strashko
On 11/09/2020 09:52, Krzysztof Kozlowski wrote: On Fri, 11 Sep 2020 at 08:24, Joel Stanley wrote: On Thu, 10 Sep 2020 at 17:57, Krzysztof Kozlowski wrote: Convert the NXP PCA953x family of GPIO expanders bindings to device tree schema. Signed-off-by: Krzysztof Kozlowski +patternProp

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-10 Thread Krzysztof Kozlowski
On Fri, 11 Sep 2020 at 08:42, Geert Uytterhoeven wrote: > > Hi Krzysztof, > > On Thu, Sep 10, 2020 at 8:54 PM Krzysztof Kozlowski wrote: > > On Thu, 10 Sep 2020 at 20:28, Nishanth Menon wrote: > > > On 19:57-20200910, Krzysztof Kozlowski wrote: > > > [...] > > > > + wakeup-source: > > > > +

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-10 Thread Krzysztof Kozlowski
On Fri, 11 Sep 2020 at 08:24, Joel Stanley wrote: > > On Thu, 10 Sep 2020 at 17:57, Krzysztof Kozlowski wrote: > > > > Convert the NXP PCA953x family of GPIO expanders bindings to device tree > > schema. > > > > Signed-off-by: Krzysztof Kozlowski > > > +patternProperties: > > + "^(hog-[0-9]+|.+

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-10 Thread Geert Uytterhoeven
Hi Krzysztof, On Thu, Sep 10, 2020 at 8:54 PM Krzysztof Kozlowski wrote: > On Thu, 10 Sep 2020 at 20:28, Nishanth Menon wrote: > > On 19:57-20200910, Krzysztof Kozlowski wrote: > > [...] > > > + wakeup-source: > > > +$ref: /schemas/types.yaml#/definitions/flag > > > + > > > +patternProperti

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-10 Thread Joel Stanley
On Thu, 10 Sep 2020 at 17:57, Krzysztof Kozlowski wrote: > > Convert the NXP PCA953x family of GPIO expanders bindings to device tree > schema. > > Signed-off-by: Krzysztof Kozlowski > +patternProperties: > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > +type: object > +properties: > + gpi

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-10 Thread Nishanth Menon
On 20:53-20200910, Krzysztof Kozlowski wrote: > On Thu, 10 Sep 2020 at 20:28, Nishanth Menon wrote: > > > > On 19:57-20200910, Krzysztof Kozlowski wrote: > > [...] > > > + wakeup-source: > > > +$ref: /schemas/types.yaml#/definitions/flag > > > + > > > +patternProperties: > > > + "^(hog-[0-9]

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-10 Thread Krzysztof Kozlowski
On Thu, 10 Sep 2020 at 20:28, Nishanth Menon wrote: > > On 19:57-20200910, Krzysztof Kozlowski wrote: > [...] > > + wakeup-source: > > +$ref: /schemas/types.yaml#/definitions/flag > > + > > +patternProperties: > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > > I wonder if "hog" is too generic and

Re: [PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-10 Thread Nishanth Menon
On 19:57-20200910, Krzysztof Kozlowski wrote: [...] > + wakeup-source: > +$ref: /schemas/types.yaml#/definitions/flag > + > +patternProperties: > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": I wonder if "hog" is too generic and might clash with "something-hog" in the future? -- Regards, Nishanth M

[PATCH v2 01/15] dt-bindings: gpio: convert bindings for NXP PCA953x family to dtschema

2020-09-10 Thread Krzysztof Kozlowski
Convert the NXP PCA953x family of GPIO expanders bindings to device tree schema. Signed-off-by: Krzysztof Kozlowski --- Changes since v1: 1. Use additionalProperties. 2. Add wakeup-source. 3. Add hogs. 4. Extend example with hogs. --- .../devicetree/bindings/gpio/gpio-pca953x.txt | 90 ---