Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

Are you planning on re-submitting this patch-set anytime soon? I thought Tony said it was important? -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "u

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

On Mon, Dec 02, 2013 at 09:42:54PM -0600, Felipe Balbi wrote: > we could build that as a driver. What is "that". How can it not be a driver? Do you mean modular? In that case there is no problem, the only thing that doesn't work is unloading the module. Best regards Uwe > Signed-off-by: Felipe B

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

Hi, On Tue, Dec 10, 2013 at 08:50:07AM +, Lee Jones wrote: > > > > > The code looks mostly fine, but the implementation of the commit logs > > > > > seems lazy. Please submit a v3 using coherent sentences with full > > > > > explanations and correct punctuation. > > > > > > > > example ? > >

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

> > > > The code looks mostly fine, but the implementation of the commit logs > > > > seems lazy. Please submit a v3 using coherent sentences with full > > > > explanations and correct punctuation. > > > > > > example ? > > > > All of your commit messages. > > > > > that macro just helps removin

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

Hi, On Mon, Dec 09, 2013 at 09:37:48AM +, Lee Jones wrote: > > > The code looks mostly fine, but the implementation of the commit logs > > > seems lazy. Please submit a v3 using coherent sentences with full > > > explanations and correct punctuation. > > > > example ? > > All of your commit

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

> > The code looks mostly fine, but the implementation of the commit logs > > seems lazy. Please submit a v3 using coherent sentences with full > > explanations and correct punctuation. > > example ? All of your commit messages. > that macro just helps removing some extra ^- Sentences start w

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

On Tue, Dec 03, 2013 at 09:51:36AM +, Lee Jones wrote: > The code looks mostly fine, but the implementation of the commit logs > seems lazy. Please submit a v3 using coherent sentences with full > explanations and correct punctuation. example ? -- balbi signature.asc Description: Digital s

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

Hi, For the whole series: Tested-by: Aaro Koskinen A. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lk

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

> The code looks mostly fine, but the implementation of the commit logs > seems lazy. Please submit a v3 using coherent sentences with full > explanations and correct punctuation. Also use the full length of the provided buffer, which I believe is 72 chars, but happy to be correct on that one. It'

Re: [PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

The code looks mostly fine, but the implementation of the commit logs seems lazy. Please submit a v3 using coherent sentences with full explanations and correct punctuation. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Face

[PATCH v2 01/15] mfd: menelaus: Drop __exit section annotation

we could build that as a driver. Signed-off-by: Felipe Balbi --- drivers/mfd/menelaus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/menelaus.c b/drivers/mfd/menelaus.c index ad25bfa..975ff9e 100644 --- a/drivers/mfd/menelaus.c +++ b/drivers/mfd/menelaus.c