Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-09-10 Thread Sami Tolvanen
On Tue, Sep 10, 2024 at 2:44 AM Masahiro Yamada wrote: > > On Fri, Sep 6, 2024 at 5:53 AM Sami Tolvanen wrote: > > > > Thanks for the patch! I think this would otherwise work, but I also > > need jhash (or a similar hash function), and I can't combine the > > tools/include version with this, beca

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-09-10 Thread Masahiro Yamada
On Fri, Sep 6, 2024 at 5:53 AM Sami Tolvanen wrote: > > Hi, > > On Thu, Sep 5, 2024 at 2:30 AM Masahiro Yamada wrote: > > > > On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen > > wrote: > > > > > > +++ b/scripts/gendwarfksyms/gendwarfksyms.h > > > @@ -0,0 +1,78 @@ > > > +/* SPDX-License-Identifier

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-09-05 Thread Sami Tolvanen
Hi, On Thu, Sep 5, 2024 at 2:30 AM Masahiro Yamada wrote: > > On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen wrote: > > > > +++ b/scripts/gendwarfksyms/gendwarfksyms.h > > @@ -0,0 +1,78 @@ > > +/* SPDX-License-Identifier: GPL-2.0-or-later */ > > +/* > > + * Copyright (C) 2024 Google LLC > > + */

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-09-04 Thread Masahiro Yamada
On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen wrote: > > Add a basic DWARF parser, which uses libdw to traverse the debugging > information in an object file and looks for functions and variables. > In follow-up patches, this will be expanded to produce symbol versions > for CONFIG_MODVERSIONS fro

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-08-28 Thread Sami Tolvanen
Hi Masahiro, On Thu, Aug 29, 2024 at 02:45:03AM +0900, Masahiro Yamada wrote: > On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen wrote: > > +static int usage(void) > > +{ > > + error("usage: gendwarfksyms [options] elf-object-file ..."); > > > > Description for each option, please. Sure, w

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-08-28 Thread Sami Tolvanen
On Wed, Aug 28, 2024 at 02:31:05PM +0200, Petr Pavlu wrote: > On 8/26/24 20:47, Sami Tolvanen wrote: > > How do you propose using the function? This loop goes through multiple > > input files, should we need them, and we iterate through all the CUs > > in process_modules. > > I was thinking it cou

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-08-28 Thread Masahiro Yamada
On Fri, Aug 16, 2024 at 2:39 AM Sami Tolvanen wrote: > > Add a basic DWARF parser, which uses libdw to traverse the debugging > information in an object file and looks for functions and variables. > In follow-up patches, this will be expanded to produce symbol versions > for CONFIG_MODVERSIONS fro

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-08-28 Thread Petr Pavlu
On 8/26/24 20:47, Sami Tolvanen wrote: > On Mon, Aug 26, 2024 at 10:42 AM Petr Pavlu wrote: >> On 8/15/24 19:39, Sami Tolvanen wrote: >>> [...] >>> +int main(int argc, const char **argv) >>> +{ >>> + unsigned int n; >>> + >>> + if (parse_options(argc, argv) < 0) >>> + return us

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-08-27 Thread Sami Tolvanen
Hi Greg, On Fri, Aug 16, 2024 at 12:14 AM Greg Kroah-Hartman wrote: > > On Thu, Aug 15, 2024 at 05:39:05PM +, Sami Tolvanen wrote: > > --- /dev/null > > +++ b/scripts/gendwarfksyms/dwarf.c > > @@ -0,0 +1,87 @@ > > +// SPDX-License-Identifier: GPL-2.0-or-later > > Sorry, but I have to ask, do

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-08-26 Thread Sami Tolvanen
Hi Petr, On Mon, Aug 26, 2024 at 10:42 AM Petr Pavlu wrote: > > On 8/15/24 19:39, Sami Tolvanen wrote: > > +static int parse_options(int argc, const char **argv) > > +{ > > + for (int i = 1; i < argc; i++) { > > + bool flag = false; > > + > > + for (int j = 0; j < ARRA

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-08-26 Thread Petr Pavlu
On 8/15/24 19:39, Sami Tolvanen wrote: > Add a basic DWARF parser, which uses libdw to traverse the debugging > information in an object file and looks for functions and variables. > In follow-up patches, this will be expanded to produce symbol versions > for CONFIG_MODVERSIONS from DWARF. > > Sig

Re: [PATCH v2 01/19] tools: Add gendwarfksyms

2024-08-16 Thread Greg Kroah-Hartman
On Thu, Aug 15, 2024 at 05:39:05PM +, Sami Tolvanen wrote: > --- /dev/null > +++ b/scripts/gendwarfksyms/dwarf.c > @@ -0,0 +1,87 @@ > +// SPDX-License-Identifier: GPL-2.0-or-later Sorry, but I have to ask, do you _REALLY_ mean "or later" here and in other places in this series? If so, great,

[PATCH v2 01/19] tools: Add gendwarfksyms

2024-08-15 Thread Sami Tolvanen
Add a basic DWARF parser, which uses libdw to traverse the debugging information in an object file and looks for functions and variables. In follow-up patches, this will be expanded to produce symbol versions for CONFIG_MODVERSIONS from DWARF. Signed-off-by: Sami Tolvanen --- kernel/module/Kconf