Re: [PATCH v2 01/22] mpool: add utility routines and ioctl definitions

2020-10-12 Thread Randy Dunlap
On 10/12/20 9:45 AM, Randy Dunlap wrote: > On 10/12/20 9:27 AM, Nabeel M Mohamed wrote: >> +#define MPIOC_MAGIC ('2') > > Hi, > > That value should be documented in > Documentation/userspace-api/ioctl/ioctl-number.rst. Sorry, I see it now. thanks. -- ~Randy

Re: [PATCH v2 01/22] mpool: add utility routines and ioctl definitions

2020-10-12 Thread Randy Dunlap
On 10/12/20 9:27 AM, Nabeel M Mohamed wrote: > +#define MPIOC_MAGIC ('2') Hi, That value should be documented in Documentation/userspace-api/ioctl/ioctl-number.rst. thanks. -- ~Randy

[PATCH v2 01/22] mpool: add utility routines and ioctl definitions

2020-10-12 Thread Nabeel M Mohamed
This adds structures used by mpool ioctls and utility routines for logging, UUID management etc. The mpool ioctls can be categorized as follows: 1. IOCTLs issued to the mpool control device (/dev/mpoolctl) - Mpool life cycle management (MPIOC_MP_*) 2. IOCTLs issued to the mpool device (/dev/m