Re: [PATCH v2 02/10] MIPS: ranchu: Add Goldfish RTC driver

2017-07-06 Thread Alexandre Belloni
On 06/07/2017 at 13:25:09 +, Miodrag Dinic wrote: > > > +static int goldfish_rtc_read_time(struct device *dev, struct rtc_time > > > *tm) > > > +{ > > > + u64 time; > > > + u64 time_low; > > > + u64 time_high; > > > + u64 time_high_prev; > > > + > > > + struct goldfish_rtc

RE: [PATCH v2 02/10] MIPS: ranchu: Add Goldfish RTC driver

2017-07-06 Thread Miodrag Dinic
> > + &goldfish_rtc_ops, THIS_MODULE); > > + if (IS_ERR(qrtc->rtc)) > > + return PTR_ERR(qrtc->rtc); > > + > > + err = devm_request_irq(&pdev->dev, qrtc->irq, goldfish_rtc_interrupt, >

Re: [PATCH v2 02/10] MIPS: ranchu: Add Goldfish RTC driver

2017-07-05 Thread Alexandre Belloni
Hi, The subject doesn't fit the subsystem style, this needs to be changed. On 28/06/2017 at 17:46:55 +0200, Aleksandar Markovic wrote: > From: Aleksandar Markovic > > Add device driver for a virtual Goldfish RTC clock. > > The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are > s

[PATCH v2 02/10] MIPS: ranchu: Add Goldfish RTC driver

2017-06-28 Thread Aleksandar Markovic
From: Aleksandar Markovic Add device driver for a virtual Goldfish RTC clock. The driver can be built only if CONFIG_MIPS and CONFIG_GOLDFISH are set. The compatible string used by OS for binding the driver is defined as "google,goldfish-rtc". Signed-off-by: Miodrag Dinic Signed-off-by: Goran