Re: [PATCH v2 02/10] x86/percpu: Clean up percpu_to_op()

2020-07-10 Thread Nick Desaulniers
On Fri, Jul 10, 2020 at 1:53 AM Peter Zijlstra wrote: > > On Fri, Jul 10, 2020 at 12:38:23AM -0400, Brian Gerst wrote: > > On Thu, Jul 9, 2020 at 6:30 AM Peter Zijlstra wrote: > > > > > > On Sat, May 30, 2020 at 06:11:19PM -0400, Brian Gerst wrote: > > > > + if (0) {

Re: [PATCH v2 02/10] x86/percpu: Clean up percpu_to_op()

2020-07-10 Thread Peter Zijlstra
On Fri, Jul 10, 2020 at 12:38:23AM -0400, Brian Gerst wrote: > On Thu, Jul 9, 2020 at 6:30 AM Peter Zijlstra wrote: > > > > On Sat, May 30, 2020 at 06:11:19PM -0400, Brian Gerst wrote: > > > + if (0) {\ > > > + typeof(_var) pt

Re: [PATCH v2 02/10] x86/percpu: Clean up percpu_to_op()

2020-07-09 Thread Brian Gerst
On Thu, Jul 9, 2020 at 6:30 AM Peter Zijlstra wrote: > > On Sat, May 30, 2020 at 06:11:19PM -0400, Brian Gerst wrote: > > + if (0) {\ > > + typeof(_var) pto_tmp__; \ > > + pto_tmp__

Re: [PATCH v2 02/10] x86/percpu: Clean up percpu_to_op()

2020-07-09 Thread Peter Zijlstra
On Sat, May 30, 2020 at 06:11:19PM -0400, Brian Gerst wrote: > + if (0) {\ > + typeof(_var) pto_tmp__; \ > + pto_tmp__ = (_val); \ > +

[PATCH v2 02/10] x86/percpu: Clean up percpu_to_op()

2020-05-30 Thread Brian Gerst
The core percpu macros already have a switch on the data size, so the switch in the x86 code is redundant and produces more dead code. Also use appropriate types for the width of the instructions. This avoids errors when compiling with Clang. Signed-off-by: Brian Gerst Reviewed-by: Nick Desauln