Re: [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec

2019-10-21 Thread Lee Jones
On Mon, 21 Oct 2019, Srinivas Kandagatla wrote: > > > On 21/10/2019 12:45, Lee Jones wrote: > > On Mon, 21 Oct 2019, Srinivas Kandagatla wrote: > > > > > Thanks Lee for taking time to review. > > > > > > I agree with most of the style related comments, will fix them in next > > > version. For

Re: [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec

2019-10-21 Thread Srinivas Kandagatla
On 21/10/2019 12:45, Lee Jones wrote: On Mon, 21 Oct 2019, Srinivas Kandagatla wrote: Thanks Lee for taking time to review. I agree with most of the style related comments, will fix them in next version. For others I have replied it inline. [...] +static int wcd934x_slim_status(struct s

Re: [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec

2019-10-21 Thread Lee Jones
On Mon, 21 Oct 2019, Srinivas Kandagatla wrote: > Thanks Lee for taking time to review. > > I agree with most of the style related comments, will fix them in next > version. For others I have replied it inline. [...] > > > +static int wcd934x_bring_up(struct wcd934x_data *wcd) > > > +{ > > > +

Re: [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec

2019-10-21 Thread Srinivas Kandagatla
Thanks Lee for taking time to review. I agree with most of the style related comments, will fix them in next version. For others I have replied it inline. On 21/10/2019 11:46, Lee Jones wrote: On Fri, 18 Oct 2019, Srinivas Kandagatla wrote: Qualcomm WCD9340/WCD9341 Codec is a standalone Hi-

Re: [PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec

2019-10-21 Thread Lee Jones
On Fri, 18 Oct 2019, Srinivas Kandagatla wrote: > Qualcomm WCD9340/WCD9341 Codec is a standalone Hi-Fi audio codec IC. > > This codec has integrated SoundWire controller, pin controller and > interrupt controller. > > Signed-off-by: Srinivas Kandagatla > --- > drivers/mfd/Kconfig

[PATCH v2 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec

2019-10-17 Thread Srinivas Kandagatla
Qualcomm WCD9340/WCD9341 Codec is a standalone Hi-Fi audio codec IC. This codec has integrated SoundWire controller, pin controller and interrupt controller. Signed-off-by: Srinivas Kandagatla --- drivers/mfd/Kconfig | 8 + drivers/mfd/Makefile | 1 + driv