Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-26 Thread Borislav Petkov
On Mon, Apr 25, 2016 at 11:48:19AM -0400, Boris Ostrovsky wrote: > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/x86/boot.txt#n1096 > > is what I was referring to. Right, so reportedly those two weren't meant to be entry points initially but stuff is using the

Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-25 Thread David Vrabel
On 24/04/16 21:23, Borislav Petkov wrote: > On Mon, Feb 01, 2016 at 10:38:48AM -0500, Boris Ostrovsky wrote: >> Start HVMlite guest at XEN_ELFNOTE_PHYS32_ENTRY address. Setup hypercall >> page, initialize boot_params, enable early page tables. >> >> Since this stub is executed before kernel entry p

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-25 Thread Boris Ostrovsky
On 04/25/2016 11:22 AM, Borislav Petkov wrote: On Mon, Apr 25, 2016 at 10:42:15AM -0400, Boris Ostrovsky wrote: Hmm... I thought that everything specified in boot.txt was ABI. But those are not there. https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/x86/boo

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-25 Thread Borislav Petkov
On Mon, Apr 25, 2016 at 10:42:15AM -0400, Boris Ostrovsky wrote: > Hmm... I thought that everything specified in boot.txt was ABI. But those are not there. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-25 Thread Boris Ostrovsky
On 04/25/2016 10:11 AM, Borislav Petkov wrote: On Mon, Apr 25, 2016 at 09:54:37AM -0400, Boris Ostrovsky wrote: Yes, those. I don't think the ones in arch/x86/kernel/head_{32,64}.S are ABI. Hmm... I thought that everything specified in boot.txt was ABI. I don't think we can jump to compress

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-25 Thread Borislav Petkov
On Mon, Apr 25, 2016 at 09:54:37AM -0400, Boris Ostrovsky wrote: > Yes, those. I don't think the ones in arch/x86/kernel/head_{32,64}.S are ABI. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-25 Thread Boris Ostrovsky
On 04/25/2016 09:47 AM, Borislav Petkov wrote: On Mon, Apr 25, 2016 at 09:21:27AM -0400, Boris Ostrovsky wrote: I was following Documentation/x86/boot.txt (plus comments in code preceding those two routines) which I considered to be the API. We are supposed to come to startup_32 with paging of

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-25 Thread Borislav Petkov
On Mon, Apr 25, 2016 at 09:21:27AM -0400, Boris Ostrovsky wrote: > I was following Documentation/x86/boot.txt (plus comments in code preceding > those two routines) which I considered to be the API. > > We are supposed to come to startup_32 with paging off and %esi pointing to > boot_params. For

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-25 Thread Boris Ostrovsky
On 04/24/2016 04:23 PM, Borislav Petkov wrote: On Mon, Feb 01, 2016 at 10:38:48AM -0500, Boris Ostrovsky wrote: Start HVMlite guest at XEN_ELFNOTE_PHYS32_ENTRY address. Setup hypercall page, initialize boot_params, enable early page tables. Since this stub is executed before kernel entry point

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-24 Thread Borislav Petkov
On Mon, Feb 01, 2016 at 10:38:48AM -0500, Boris Ostrovsky wrote: > Start HVMlite guest at XEN_ELFNOTE_PHYS32_ENTRY address. Setup hypercall > page, initialize boot_params, enable early page tables. > > Since this stub is executed before kernel entry point we cannot use > variables in .bss which is

Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-04-05 Thread Luis R. Rodriguez
On Thu, Feb 4, 2016 at 3:10 PM, Luis R. Rodriguez wrote: > On Thu, Feb 04, 2016 at 12:51:38AM +, Andrew Cooper wrote: >> On 03/02/2016 23:59, Luis R. Rodriguez wrote: >> > On Wed, Feb 03, 2016 at 08:52:50PM +, Andrew Cooper wrote: >> >> On 03/02/16 18:55, Luis R. Rodriguez wrote: >> >>> We

Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-04 Thread Luis R. Rodriguez
On Thu, Feb 04, 2016 at 12:51:38AM +, Andrew Cooper wrote: > On 03/02/2016 23:59, Luis R. Rodriguez wrote: > > On Wed, Feb 03, 2016 at 08:52:50PM +, Andrew Cooper wrote: > >> On 03/02/16 18:55, Luis R. Rodriguez wrote: > >>> We add new hypervisor type to close the semantic gap for hyperviso

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-04 Thread Boris Ostrovsky
On 02/04/2016 03:57 PM, Luis R. Rodriguez wrote: Ah, well here lies the issue. As per hpa subarch was not designed for defining a hypervisor, but rather at least subarch PC (0) [should be used if the hardware is] "enumerable using standard PC mechanisms (PCI, ACPI) and doesn't need a special boo

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-04 Thread Luis R. Rodriguez
On Thu, Feb 04, 2016 at 02:54:15PM -0500, Boris Ostrovsky wrote: > On 02/03/2016 06:40 PM, Luis R. Rodriguez wrote: > >On Wed, Feb 03, 2016 at 03:11:56PM -0500, Boris Ostrovsky wrote: > >>On 02/03/2016 01:55 PM, Luis R. Rodriguez wrote: > >>>I saw no considerations for the recommendations I had mad

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-04 Thread Boris Ostrovsky
On 02/03/2016 06:40 PM, Luis R. Rodriguez wrote: On Wed, Feb 03, 2016 at 03:11:56PM -0500, Boris Ostrovsky wrote: On 02/03/2016 01:55 PM, Luis R. Rodriguez wrote: I saw no considerations for the recommendations I had made last on your v1: https://lkml.kernel.org/r/CAB=NE6XPA0YzbnM8=rspkkai6d3g

Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-03 Thread Andrew Cooper
On 03/02/2016 23:59, Luis R. Rodriguez wrote: > On Wed, Feb 03, 2016 at 08:52:50PM +, Andrew Cooper wrote: >> On 03/02/16 18:55, Luis R. Rodriguez wrote: >>> We add new hypervisor type to close the semantic gap for hypervisor types, >>> and >>> much like subarch enable also a subarch_data to l

Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-03 Thread Luis R. Rodriguez
On Wed, Feb 3, 2016 at 3:59 PM, Luis R. Rodriguez wrote: >> If you still desperately want to avoid multiple entry points, then just >> insist on using grub for the VM. I expect that that is how most people >> will end up using HVMLite VMs anyway. > > Are you saying Grub can do some of this heavy

Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-03 Thread Luis R. Rodriguez
On Wed, Feb 03, 2016 at 08:52:50PM +, Andrew Cooper wrote: > On 03/02/16 18:55, Luis R. Rodriguez wrote: > > We add new hypervisor type to close the semantic gap for hypervisor types, > > and > > much like subarch enable also a subarch_data to let you pass and use your > > hvmlite_start_info.

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-03 Thread Luis R. Rodriguez
On Wed, Feb 03, 2016 at 03:11:56PM -0500, Boris Ostrovsky wrote: > On 02/03/2016 01:55 PM, Luis R. Rodriguez wrote: > >I saw no considerations for the recommendations I had made last on your v1: > > > >https://lkml.kernel.org/r/CAB=NE6XPA0YzbnM8=rspkkai6d3gkxxo00gr0vzuyoyzny6...@mail.gmail.com > >

Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-03 Thread Andrew Cooper
On 03/02/16 18:55, Luis R. Rodriguez wrote: > We add new hypervisor type to close the semantic gap for hypervisor types, and > much like subarch enable also a subarch_data to let you pass and use your > hvmlite_start_info. This would not only help with the semantics but also help > avoid yet-anothe

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-03 Thread Boris Ostrovsky
On 02/03/2016 01:55 PM, Luis R. Rodriguez wrote: I saw no considerations for the recommendations I had made last on your v1: https://lkml.kernel.org/r/CAB=NE6XPA0YzbnM8=rspkkai6d3gkxxo00gr0vzuyoyzny6...@mail.gmail.com Of importance: 1) Using pv_info.paravirt_enabled = 1 is wrong unless you mea

Re: [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-03 Thread Luis R. Rodriguez
I saw no considerations for the recommendations I had made last on your v1: https://lkml.kernel.org/r/CAB=NE6XPA0YzbnM8=rspkkai6d3gkxxo00gr0vzuyoyzny6...@mail.gmail.com Of importance: 1) Using pv_info.paravirt_enabled = 1 is wrong unless you mean to say this is for legacy x86: Your patch #3

Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-02 Thread Boris Ostrovsky
On 02/02/2016 11:39 AM, David Vrabel wrote: On 01/02/16 15:38, Boris Ostrovsky wrote: --- a/include/xen/xen.h +++ b/include/xen/xen.h @@ -29,6 +29,12 @@ extern enum xen_domain_type xen_domain_type; #define xen_initial_domain() (0) #endif/* CONFIG_XEN_DOM0 */ +#ifdef CONFIG_XEN_PV

Re: [Xen-devel] [PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-02 Thread David Vrabel
On 01/02/16 15:38, Boris Ostrovsky wrote: > --- a/include/xen/xen.h > +++ b/include/xen/xen.h > @@ -29,6 +29,12 @@ extern enum xen_domain_type xen_domain_type; > #define xen_initial_domain() (0) > #endif /* CONFIG_XEN_DOM0 */ > > +#ifdef CONFIG_XEN_PVHVM > +extern int xen_hvmlite; > +#els

[PATCH v2 02/11] xen/hvmlite: Bootstrap HVMlite guest

2016-02-01 Thread Boris Ostrovsky
Start HVMlite guest at XEN_ELFNOTE_PHYS32_ENTRY address. Setup hypercall page, initialize boot_params, enable early page tables. Since this stub is executed before kernel entry point we cannot use variables in .bss which is cleared by kernel. We explicitly place variables that are initialized here