Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread John Garry
The syscon block is a general subsystem control block, and it is not specifically only for controlling reset and enabling clocks (other functions include serdes control, for example). It is also shared with other peripherals. So we can remove the ctrl-reg property (since it is not part of the

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread Mark Rutland
> + - ctrl-reg : offset to the following SAS control registers (in order): > + - reset assert > + - clock disable > + - reset status > + - reset de-assert > + - clock enable [...] > >It would be better to have each offset in a

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread zhangfei
On 10/27/2015 10:39 PM, Mark Rutland wrote: On Tue, Oct 27, 2015 at 01:09:15PM +, John Garry wrote: On 26/10/2015 14:45, Mark Rutland wrote: On Mon, Oct 26, 2015 at 10:14:33PM +0800, John Garry wrote: Add devicetree bindings for HiSilicon SAS driver. Signed-off-by: John Garry ---

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread Mark Rutland
On Tue, Oct 27, 2015 at 01:09:15PM +, John Garry wrote: > On 26/10/2015 14:45, Mark Rutland wrote: > >On Mon, Oct 26, 2015 at 10:14:33PM +0800, John Garry wrote: > >>Add devicetree bindings for HiSilicon SAS driver. > >> > >>Signed-off-by: John Garry > >>--- > >>

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread John Garry
On 26/10/2015 14:45, Mark Rutland wrote: On Mon, Oct 26, 2015 at 10:14:33PM +0800, John Garry wrote: Add devicetree bindings for HiSilicon SAS driver. Signed-off-by: John Garry --- .../devicetree/bindings/scsi/hisilicon-sas.txt | 70 ++ 1 file changed, 70

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread John Garry
On 26/10/2015 14:45, Mark Rutland wrote: On Mon, Oct 26, 2015 at 10:14:33PM +0800, John Garry wrote: Add devicetree bindings for HiSilicon SAS driver. Signed-off-by: John Garry --- .../devicetree/bindings/scsi/hisilicon-sas.txt | 70 ++ 1 file

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread Mark Rutland
On Tue, Oct 27, 2015 at 01:09:15PM +, John Garry wrote: > On 26/10/2015 14:45, Mark Rutland wrote: > >On Mon, Oct 26, 2015 at 10:14:33PM +0800, John Garry wrote: > >>Add devicetree bindings for HiSilicon SAS driver. > >> > >>Signed-off-by: John Garry > >>--- > >>

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread zhangfei
On 10/27/2015 10:39 PM, Mark Rutland wrote: On Tue, Oct 27, 2015 at 01:09:15PM +, John Garry wrote: On 26/10/2015 14:45, Mark Rutland wrote: On Mon, Oct 26, 2015 at 10:14:33PM +0800, John Garry wrote: Add devicetree bindings for HiSilicon SAS driver. Signed-off-by: John Garry

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread John Garry
The syscon block is a general subsystem control block, and it is not specifically only for controlling reset and enabling clocks (other functions include serdes control, for example). It is also shared with other peripherals. So we can remove the ctrl-reg property (since it is not part of the

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread Mark Rutland
> + - ctrl-reg : offset to the following SAS control registers (in order): > + - reset assert > + - clock disable > + - reset status > + - reset de-assert > + - clock enable [...] > >It would be better to have each offset in a

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-26 Thread John Garry
On 26/10/2015 14:14, John Garry wrote: Add devicetree bindings for HiSilicon SAS driver. Signed-off-by: John Garry --- .../devicetree/bindings/scsi/hisilicon-sas.txt | 70 ++ 1 file changed, 70 insertions(+) create mode 100644

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-26 Thread Mark Rutland
On Mon, Oct 26, 2015 at 10:14:33PM +0800, John Garry wrote: > Add devicetree bindings for HiSilicon SAS driver. > > Signed-off-by: John Garry > --- > .../devicetree/bindings/scsi/hisilicon-sas.txt | 70 > ++ > 1 file changed, 70 insertions(+) > create mode 100644

[PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-26 Thread John Garry
Add devicetree bindings for HiSilicon SAS driver. Signed-off-by: John Garry --- .../devicetree/bindings/scsi/hisilicon-sas.txt | 70 ++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/scsi/hisilicon-sas.txt diff --git

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-26 Thread Mark Rutland
On Mon, Oct 26, 2015 at 10:14:33PM +0800, John Garry wrote: > Add devicetree bindings for HiSilicon SAS driver. > > Signed-off-by: John Garry > --- > .../devicetree/bindings/scsi/hisilicon-sas.txt | 70 > ++ > 1 file changed, 70 insertions(+) >

[PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-26 Thread John Garry
Add devicetree bindings for HiSilicon SAS driver. Signed-off-by: John Garry --- .../devicetree/bindings/scsi/hisilicon-sas.txt | 70 ++ 1 file changed, 70 insertions(+) create mode 100644 Documentation/devicetree/bindings/scsi/hisilicon-sas.txt

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-26 Thread John Garry
On 26/10/2015 14:14, John Garry wrote: Add devicetree bindings for HiSilicon SAS driver. Signed-off-by: John Garry --- .../devicetree/bindings/scsi/hisilicon-sas.txt | 70 ++ 1 file changed, 70 insertions(+) create mode 100644