Re: [linux-sunxi] [PATCH v2 03/11] pinctrl: sunxi: v3s: introduce support for V3

2019-06-12 Thread Paul Kocialkowski
Hi, On Tue, 2019-06-11 at 22:09 +0800, Icenowy Zheng wrote: > Introduce the GPIO pins that is only available on V3 (not on V3s) to the > V3s pinctrl driver. Looks like my comments from v1 still apply here and some of the functions are not properly described (e.g. LCD is usually 0x2 and LVDS 0x3 w

Re: [PATCH v2 03/11] pinctrl: sunxi: v3s: introduce support for V3

2019-06-11 Thread Maxime Ripard
Hi, On Tue, Jun 11, 2019 at 10:09:32PM +0800, Icenowy Zheng wrote: > Introduce the GPIO pins that is only available on V3 (not on V3s) to the > V3s pinctrl driver. > > Signed-off-by: Icenowy Zheng > --- > Changes in v2: > - Dropped the driver rename patch and apply the changes directly on V3s >

[PATCH v2 03/11] pinctrl: sunxi: v3s: introduce support for V3

2019-06-11 Thread Icenowy Zheng
Introduce the GPIO pins that is only available on V3 (not on V3s) to the V3s pinctrl driver. Signed-off-by: Icenowy Zheng --- Changes in v2: - Dropped the driver rename patch and apply the changes directly on V3s driver. drivers/pinctrl/sunxi/pinctrl-sun8i-v3s.c | 265 +-