Re: [PATCH v2 03/11] sched,idle,rcu: Push rcu_idle deeper into the idle path

2020-09-02 Thread peterz
On Thu, Aug 27, 2020 at 06:30:01PM -0400, Joel Fernandes wrote: > On Thu, Aug 27, 2020 at 09:47:48AM +0200, pet...@infradead.org wrote: > > All trace_*_rcuidle() and RCU_NONIDLE() usage is a bug IMO. > > > > Ideally RCU-trace goes away too. > > I was thinking that unless the rcu_idle_enter/exit

Re: [PATCH v2 03/11] sched,idle,rcu: Push rcu_idle deeper into the idle path

2020-08-27 Thread Joel Fernandes
On Thu, Aug 27, 2020 at 09:47:48AM +0200, pet...@infradead.org wrote: > On Wed, Aug 26, 2020 at 09:24:19PM -0400, Joel Fernandes wrote: > > On Wed, Aug 26, 2020 at 09:18:26PM -0400, Joel Fernandes wrote: > > > On Fri, Aug 21, 2020 at 10:47:41AM +0200, Peter Zijlstra wrote: > > > > Lots of things ta

Re: [PATCH v2 03/11] sched,idle,rcu: Push rcu_idle deeper into the idle path

2020-08-27 Thread Thomas Gleixner
On Thu, Aug 27 2020 at 09:47, peterz wrote: > On Wed, Aug 26, 2020 at 09:24:19PM -0400, Joel Fernandes wrote: >> On Wed, Aug 26, 2020 at 09:18:26PM -0400, Joel Fernandes wrote: >> > On Fri, Aug 21, 2020 at 10:47:41AM +0200, Peter Zijlstra wrote: >> > > Lots of things take locks, due to a wee bug, r

Re: [PATCH v2 03/11] sched,idle,rcu: Push rcu_idle deeper into the idle path

2020-08-27 Thread peterz
On Wed, Aug 26, 2020 at 09:24:19PM -0400, Joel Fernandes wrote: > On Wed, Aug 26, 2020 at 09:18:26PM -0400, Joel Fernandes wrote: > > On Fri, Aug 21, 2020 at 10:47:41AM +0200, Peter Zijlstra wrote: > > > Lots of things take locks, due to a wee bug, rcu_lockdep didn't notice > > > that the locking t

Re: [PATCH v2 03/11] sched,idle,rcu: Push rcu_idle deeper into the idle path

2020-08-26 Thread Joel Fernandes
On Wed, Aug 26, 2020 at 09:18:26PM -0400, Joel Fernandes wrote: > On Fri, Aug 21, 2020 at 10:47:41AM +0200, Peter Zijlstra wrote: > > Lots of things take locks, due to a wee bug, rcu_lockdep didn't notice > > that the locking tracepoints were using RCU. > > > > Push rcu_idle_{enter,exit}() as deep

Re: [PATCH v2 03/11] sched,idle,rcu: Push rcu_idle deeper into the idle path

2020-08-26 Thread Joel Fernandes
On Fri, Aug 21, 2020 at 10:47:41AM +0200, Peter Zijlstra wrote: > Lots of things take locks, due to a wee bug, rcu_lockdep didn't notice > that the locking tracepoints were using RCU. > > Push rcu_idle_{enter,exit}() as deep as possible into the idle paths, > this also resolves a lot of _rcuidle()

[PATCH v2 03/11] sched,idle,rcu: Push rcu_idle deeper into the idle path

2020-08-21 Thread Peter Zijlstra
Lots of things take locks, due to a wee bug, rcu_lockdep didn't notice that the locking tracepoints were using RCU. Push rcu_idle_{enter,exit}() as deep as possible into the idle paths, this also resolves a lot of _rcuidle()/RCU_NONIDLE() usage. Specifically, sched_clock_idle_wakeup_event() will