Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-19 Thread Miquel Raynal
Hi Marek, Marek BehĂșn wrote on Wed, 19 Dec 2018 16:28:35 +0100: > Hi, > > One thing for which I would like to be able to disable comphy is that > each consumes about 100mW of power. On Turris Mox we configure the > comphys to SGMII1, PCIe and USB3 modes. If there is no USB device > plugged, the

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-19 Thread Marek BehĂșn
Hi, One thing for which I would like to be able to disable comphy is that each consumes about 100mW of power. On Turris Mox we configure the comphys to SGMII1, PCIe and USB3 modes. If there is no USB device plugged, the USB3 phy can be disabled, and save 100mW of power. If the PCIe extension modul

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-18 Thread Miquel Raynal
Hi Marek, Marek Behun wrote on Tue, 18 Dec 2018 14:09:20 +0100: > > [2] > > https://github.com/ARM-software/arm-trusted-firmware/blob/master/drivers/marvell/comphy/phy-comphy-3700.c > > > > Yes, I used mainline atf (it did not work out of the box with 18.09 > atf-marvell of course). But ther

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-18 Thread Marek Behun
> [2] > https://github.com/ARM-software/arm-trusted-firmware/blob/master/drivers/marvell/comphy/phy-comphy-3700.c Yes, I used mainline atf (it did not work out of the box with 18.09 atf-marvell of course). But there is no _power_off function for SGMII, nor a digital_reset function like in cp110 im

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-18 Thread Miquel Raynal
Hello, Miquel Raynal wrote on Tue, 18 Dec 2018 09:18:17 +0100: > Hi Marek, > > Marek Behun wrote on Mon, 17 Dec 2018 22:34:30 > +0100: > > > Miquel, > > > > I tried the patches and they are working, with the exception of Compex > > WLE900X card, but we know that this card is problematic. >

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-18 Thread Miquel Raynal
Hi Marek, Marek Behun wrote on Mon, 17 Dec 2018 22:34:30 +0100: > Miquel, > > I tried the patches and they are working, with the exception of Compex > WLE900X card, but we know that this card is problematic. How did you test them? I am surprised that COMPHY calls worked for you out of the box.

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-18 Thread Miquel Raynal
Hi Baruch, Baruch Siach wrote on Mon, 17 Dec 2018 20:27:42 +0200: > Hi Miquel, > > Miquel Raynal writes: > > Marek Behun wrote on Fri, 14 Dec 2018 01:57:12 > > +0100: > > > >> On Fri, 14 Dec 2018 01:47:01 +0100 > >> Marek Behun wrote: > >> > >> > are there already patches for the A37xx c

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-17 Thread Marek Behun
Miquel, I tried the patches and they are working, with the exception of Compex WLE900X card, but we know that this card is problematic. I am interesting if there is a known way to turn of the comphy on A3720, or at least change the SGMII mode from 1Gbps to 2.5Gbps and back. Marvell documentation d

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-17 Thread Baruch Siach
Hi Miquel, Miquel Raynal writes: > Marek Behun wrote on Fri, 14 Dec 2018 01:57:12 > +0100: > >> On Fri, 14 Dec 2018 01:47:01 +0100 >> Marek Behun wrote: >> >> > are there already patches for the A37xx comphy driver? > > Please try the latest patches on top of phy -next (with PHY interface > m

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-17 Thread Miquel Raynal
Hi Marek, Marek Behun wrote on Fri, 14 Dec 2018 01:57:12 +0100: > On Fri, 14 Dec 2018 01:47:01 +0100 > Marek Behun wrote: > > > Hi Miquel, > > are there already patches for the A37xx comphy driver? Please try the latest patches on top of phy -next (with PHY interface mode), available there

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-13 Thread Marek Behun
On Fri, 14 Dec 2018 01:47:01 +0100 Marek Behun wrote: > Hi Miquel, > are there already patches for the A37xx comphy driver? Never mind, I found them. I shall test this on Turris Mox. Is the comphy driver supposed to be able to change eth mode from 1000BASE-X to 2500BASE-X and back without reboot

Re: [PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-13 Thread Marek Behun
Hi Miquel, are there already patches for the A37xx comphy driver? On Wed, 12 Dec 2018 11:21:33 +0100 Miquel Raynal wrote: > The IP needs its PHY to be properly configured to work. While the PHY > is usually already configured by the bootloader, we will need this > feature when adding S2RAM suppo

[PATCH v2 03/12] PCI: aardvark: Add PHY support

2018-12-12 Thread Miquel Raynal
The IP needs its PHY to be properly configured to work. While the PHY is usually already configured by the bootloader, we will need this feature when adding S2RAM support. Take care of registering and configuring the PHY from the driver itself. Suggested-by: Grzegorz Jaszczyk Signed-off-by: Mique