Re: [PATCH v2 03/17] soc: qcom: ipa: main code

2019-05-31 Thread Alex Elder
On 5/31/19 4:50 PM, David Miller wrote: > From: Alex Elder > Date: Thu, 30 May 2019 22:53:34 -0500 > >> +void *route_virt; > ... >> +void *filter_virt; > ... > > If these are arrays of u64's, please declare them as "u64 *" instead of > the opaque "void *". Good idea. I hadn't paid at

Re: [PATCH v2 03/17] soc: qcom: ipa: main code

2019-05-31 Thread David Miller
From: Alex Elder Date: Thu, 30 May 2019 22:53:34 -0500 > + void *route_virt; ... > + void *filter_virt; ... If these are arrays of u64's, please declare them as "u64 *" instead of the opaque "void *".

[PATCH v2 03/17] soc: qcom: ipa: main code

2019-05-30 Thread Alex Elder
This patch includes three source files that represent some basic "main program" code for the IPA driver. They are: - "ipa.h" defines the top-level IPA structure which represents an IPA device throughout the code. - "ipa_main.c" contains the platform driver probe function, along with s