Re: [PATCH v2 04/10] rtc: max77686: Use a driver data struct instead hard-coded values

2016-01-22 Thread Laxman Dewangan
On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote: The driver has some hard-coded values such as the minimum delay needed before a RTC update or the mask used for the sec/min/hour/etc registers. Use a data structure that contains these values and pass as driver data using the

Re: [PATCH v2 04/10] rtc: max77686: Use a driver data struct instead hard-coded values

2016-01-22 Thread Laxman Dewangan
On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote: The driver has some hard-coded values such as the minimum delay needed before a RTC update or the mask used for the sec/min/hour/etc registers. Use a data structure that contains these values and pass as driver data using the

Re: [PATCH v2 04/10] rtc: max77686: Use a driver data struct instead hard-coded values

2016-01-21 Thread Javier Martinez Canillas
Hello Krzysztof, On 01/21/2016 10:00 PM, Krzysztof Kozlowski wrote: On 22.01.2016 05:23, Javier Martinez Canillas wrote: The driver has some hard-coded values such as the minimum delay needed before a RTC update or the mask used for the sec/min/hour/etc registers. Use a data structure that

Re: [PATCH v2 04/10] rtc: max77686: Use a driver data struct instead hard-coded values

2016-01-21 Thread Krzysztof Kozlowski
On 22.01.2016 05:23, Javier Martinez Canillas wrote: > The driver has some hard-coded values such as the minimum delay needed > before a RTC update or the mask used for the sec/min/hour/etc registers. > > Use a data structure that contains these values and pass as driver data > using the platform

[PATCH v2 04/10] rtc: max77686: Use a driver data struct instead hard-coded values

2016-01-21 Thread Javier Martinez Canillas
The driver has some hard-coded values such as the minimum delay needed before a RTC update or the mask used for the sec/min/hour/etc registers. Use a data structure that contains these values and pass as driver data using the platform device ID table for each device. This allows to make the

[PATCH v2 04/10] rtc: max77686: Use a driver data struct instead hard-coded values

2016-01-21 Thread Javier Martinez Canillas
The driver has some hard-coded values such as the minimum delay needed before a RTC update or the mask used for the sec/min/hour/etc registers. Use a data structure that contains these values and pass as driver data using the platform device ID table for each device. This allows to make the

Re: [PATCH v2 04/10] rtc: max77686: Use a driver data struct instead hard-coded values

2016-01-21 Thread Javier Martinez Canillas
Hello Krzysztof, On 01/21/2016 10:00 PM, Krzysztof Kozlowski wrote: On 22.01.2016 05:23, Javier Martinez Canillas wrote: The driver has some hard-coded values such as the minimum delay needed before a RTC update or the mask used for the sec/min/hour/etc registers. Use a data structure that

Re: [PATCH v2 04/10] rtc: max77686: Use a driver data struct instead hard-coded values

2016-01-21 Thread Krzysztof Kozlowski
On 22.01.2016 05:23, Javier Martinez Canillas wrote: > The driver has some hard-coded values such as the minimum delay needed > before a RTC update or the mask used for the sec/min/hour/etc registers. > > Use a data structure that contains these values and pass as driver data > using the platform