Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver

2016-02-08 Thread Greg KH
On Mon, Feb 08, 2016 at 05:17:57PM +, Vladimir Murzin wrote: > On 08/02/16 16:52, Greg KH wrote: > > On Mon, Feb 08, 2016 at 11:16:56AM +, Vladimir Murzin wrote: > >> On 07/02/16 07:11, Greg KH wrote: > + > +#define SERIAL_NAME "ttyS" > >>> > >>> You can't be "ttyS", there's alrea

Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver

2016-02-08 Thread Vladimir Murzin
On 08/02/16 16:52, Greg KH wrote: > On Mon, Feb 08, 2016 at 11:16:56AM +, Vladimir Murzin wrote: >> On 07/02/16 07:11, Greg KH wrote: + +#define SERIAL_NAME "ttyS" >>> >>> You can't be "ttyS", there's already a serial port named that, please >>> use a unique name and a new major/minor

Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver

2016-02-08 Thread Greg KH
On Mon, Feb 08, 2016 at 11:16:56AM +, Vladimir Murzin wrote: > On 07/02/16 07:11, Greg KH wrote: > >> + > >> +#define SERIAL_NAME "ttyS" > > > > You can't be "ttyS", there's already a serial port named that, please > > use a unique name and a new major/minor number (dynamic ideally). > > > >

Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver

2016-02-08 Thread Vladimir Murzin
On 07/02/16 07:11, Greg KH wrote: >> + >> +#define SERIAL_NAME "ttyS" > > You can't be "ttyS", there's already a serial port named that, please > use a unique name and a new major/minor number (dynamic ideally). > Hi Greg, I did s/ttyMPS/ttyS per your request for v1 [1]. I'm fine to change it b

Re: [PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver

2016-02-06 Thread Greg KH
On Tue, Feb 02, 2016 at 11:39:53AM +, Vladimir Murzin wrote: > This driver adds support to the UART controller found on ARM MPS2 > platform. > > Signed-off-by: Vladimir Murzin > --- > drivers/tty/serial/Kconfig | 12 + > drivers/tty/serial/Makefile |1 + > drivers/tty/serial

[PATCH v2 04/10] serial: mps2-uart: add MPS2 UART driver

2016-02-02 Thread Vladimir Murzin
This driver adds support to the UART controller found on ARM MPS2 platform. Signed-off-by: Vladimir Murzin --- drivers/tty/serial/Kconfig | 12 + drivers/tty/serial/Makefile |1 + drivers/tty/serial/mps2-uart.c | 584 ++ include/uapi/linux/