Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-30 Thread Stephen Boyd
Quoting Petr Mladek (2021-03-30 03:29:24) > On Tue 2021-03-23 19:04:35, Stephen Boyd wrote: > > Let's make kernel stacktraces easier to identify by including the build > > ID[1] of a module if the stacktrace is printing a symbol from a module. > > > > Example: > > > > WARNING: CPU: 3 PID: 3373 a

Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-30 Thread Petr Mladek
On Wed 2021-03-24 15:28:43, Stephen Boyd wrote: > Quoting Rasmus Villemoes (2021-03-24 15:21:34) > > On 24/03/2021 20.11, Stephen Boyd wrote: > > > Quoting Rasmus Villemoes (2021-03-24 02:57:13) > > > > >> > > >> Is there any reason you didn't just make b an optional flag that could > > >> be spec

Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-30 Thread Petr Mladek
On Tue 2021-03-23 19:04:35, Stephen Boyd wrote: > Let's make kernel stacktraces easier to identify by including the build > ID[1] of a module if the stacktrace is printing a symbol from a module. > > Example: > > WARNING: CPU: 3 PID: 3373 at drivers/misc/lkdtm/bugs.c:83 > lkdtm_WARNING+0x28/0x3

Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-24 Thread Stephen Boyd
Quoting Rasmus Villemoes (2021-03-24 15:21:34) > On 24/03/2021 20.11, Stephen Boyd wrote: > > Quoting Rasmus Villemoes (2021-03-24 02:57:13) > > >> > >> Is there any reason you didn't just make b an optional flag that could > >> be specified with or without R? I suppose the parsing is more difficu

Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-24 Thread Rasmus Villemoes
On 24/03/2021 20.11, Stephen Boyd wrote: > Quoting Rasmus Villemoes (2021-03-24 02:57:13) >> >> Is there any reason you didn't just make b an optional flag that could >> be specified with or without R? I suppose the parsing is more difficult >> with several orthogonal flags (see escaped_string()),

Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-24 Thread Stephen Boyd
Quoting Rasmus Villemoes (2021-03-24 02:57:13) > On 24/03/2021 03.04, Stephen Boyd wrote: > > > @@ -2778,6 +2793,10 @@ static inline void layout_symtab(struct module *mod, > > struct load_info *info) > > static void add_kallsyms(struct module *mod, const struct load_info *info) > > { > > } > >

Re: [PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-24 Thread Rasmus Villemoes
On 24/03/2021 03.04, Stephen Boyd wrote: > @@ -2778,6 +2793,10 @@ static inline void layout_symtab(struct module *mod, > struct load_info *info) > static void add_kallsyms(struct module *mod, const struct load_info *info) > { > } > + > +static void init_build_id(struct module *mod, const struc

[PATCH v2 04/12] module: Add printk format to add module build ID to stacktraces

2021-03-23 Thread Stephen Boyd
Let's make kernel stacktraces easier to identify by including the build ID[1] of a module if the stacktrace is printing a symbol from a module. This makes it simpler for developers to locate a kernel module's full debuginfo for a particular stacktrace. Combined with scripts/decode_stracktrace.sh, a