Re: [PATCH v2 04/16] b43: Remove uninitialized_var() usage

2020-07-15 Thread Kalle Valo
Kees Cook wrote: > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize the variable or make compiler changes. A

Re: [PATCH v2 04/16] b43: Remove uninitialized_var() usage

2020-06-23 Thread Nick Desaulniers
On Mon, Jun 22, 2020 at 2:04 PM Kees Cook wrote: > > On Mon, Jun 22, 2020 at 10:04:18AM -0700, Nick Desaulniers wrote: > > On Fri, Jun 19, 2020 at 8:30 PM Kees Cook wrote: > > > > > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > > (or can in the future), and suppresse

Re: [PATCH v2 04/16] b43: Remove uninitialized_var() usage

2020-06-22 Thread Kees Cook
On Mon, Jun 22, 2020 at 10:04:18AM -0700, Nick Desaulniers wrote: > On Fri, Jun 19, 2020 at 8:30 PM Kees Cook wrote: > > > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > (or can in the future), and suppresses unrelated compiler warnings (e.g. > > "unused variable"). If

Re: [PATCH v2 04/16] b43: Remove uninitialized_var() usage

2020-06-22 Thread Nick Desaulniers
On Fri, Jun 19, 2020 at 8:30 PM Kees Cook wrote: > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > (or can in the future), and suppresses unrelated compiler warnings (e.g. > "unused variable"). If the compiler thinks it is uninitialized, either > simply initialize the var

[PATCH v2 04/16] b43: Remove uninitialized_var() usage

2020-06-19 Thread Kees Cook
Using uninitialized_var() is dangerous as it papers over real bugs[1] (or can in the future), and suppresses unrelated compiler warnings (e.g. "unused variable"). If the compiler thinks it is uninitialized, either simply initialize the variable or make compiler changes. As a precursor to removing[2