Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

2018-04-01 11:27 GMT+09:00 Ulf Magnusson : > Here's a more in-depth review: > > On Tue, Mar 27, 2018 at 7:29 AM, Masahiro Yamada > wrote: >> To get an environment value, Kconfig needs to define a symbol using >> "option env=" syntax. It is

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

2018-04-01 11:27 GMT+09:00 Ulf Magnusson : > Here's a more in-depth review: > > On Tue, Mar 27, 2018 at 7:29 AM, Masahiro Yamada > wrote: >> To get an environment value, Kconfig needs to define a symbol using >> "option env=" syntax. It is tedious to add a config entry for each >> environment

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

On Sun, Apr 1, 2018 at 4:27 AM, Ulf Magnusson wrote: > > AFAICS, we only need the following functionality: > > 1. Record referenced environment variables along with their value > > 2. Go through all the recorded environment variables and write > dependency information

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

On Sun, Apr 1, 2018 at 4:27 AM, Ulf Magnusson wrote: > > AFAICS, we only need the following functionality: > > 1. Record referenced environment variables along with their value > > 2. Go through all the recorded environment variables and write > dependency information > > For (1), I think

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

Here's a more in-depth review: On Tue, Mar 27, 2018 at 7:29 AM, Masahiro Yamada wrote: > To get an environment value, Kconfig needs to define a symbol using > "option env=" syntax. It is tedious to add a config entry for each > environment given that we need more

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

Here's a more in-depth review: On Tue, Mar 27, 2018 at 7:29 AM, Masahiro Yamada wrote: > To get an environment value, Kconfig needs to define a symbol using > "option env=" syntax. It is tedious to add a config entry for each > environment given that we need more environments such as 'CC',

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

2018-03-29 11:19 GMT+09:00 Ulf Magnusson :. >> %% >> +static void expand_string(const char *in) >> +{ >> + char *p, *q; >> + >> + p = expand_string_value(in); >> + >> + q = p + strlen(p); >> + while (q > p) >> + unput(*--q); >> + >> +

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

2018-03-29 11:19 GMT+09:00 Ulf Magnusson :. >> %% >> +static void expand_string(const char *in) >> +{ >> + char *p, *q; >> + >> + p = expand_string_value(in); >> + >> + q = p + strlen(p); >> + while (q > p) >> + unput(*--q); >> + >> + free(p); >> +} >>

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

On Thu, Mar 29, 2018 at 4:56 AM, Ulf Magnusson wrote: > On Thu, Mar 29, 2018 at 4:19 AM, Ulf Magnusson wrote: >> I've been kinda busy lately, so that's why I disappeared. >> >> I'll try to go over this patchset in more detail over the weekend. >> >> On

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

On Thu, Mar 29, 2018 at 4:56 AM, Ulf Magnusson wrote: > On Thu, Mar 29, 2018 at 4:19 AM, Ulf Magnusson wrote: >> I've been kinda busy lately, so that's why I disappeared. >> >> I'll try to go over this patchset in more detail over the weekend. >> >> On Tue, Mar 27, 2018 at 7:29 AM, Masahiro

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

On Thu, Mar 29, 2018 at 4:19 AM, Ulf Magnusson wrote: > I've been kinda busy lately, so that's why I disappeared. > > I'll try to go over this patchset in more detail over the weekend. > > On Tue, Mar 27, 2018 at 7:29 AM, Masahiro Yamada >

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

On Thu, Mar 29, 2018 at 4:19 AM, Ulf Magnusson wrote: > I've been kinda busy lately, so that's why I disappeared. > > I'll try to go over this patchset in more detail over the weekend. > > On Tue, Mar 27, 2018 at 7:29 AM, Masahiro Yamada > wrote: >> To get an environment value, Kconfig needs to

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

I've been kinda busy lately, so that's why I disappeared. I'll try to go over this patchset in more detail over the weekend. On Tue, Mar 27, 2018 at 7:29 AM, Masahiro Yamada wrote: > To get an environment value, Kconfig needs to define a symbol using > "option

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

I've been kinda busy lately, so that's why I disappeared. I'll try to go over this patchset in more detail over the weekend. On Tue, Mar 27, 2018 at 7:29 AM, Masahiro Yamada wrote: > To get an environment value, Kconfig needs to define a symbol using > "option env=" syntax. It is tedious to

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

On Mon, Mar 26, 2018 at 10:29 PM, Masahiro Yamada wrote: > To get an environment value, Kconfig needs to define a symbol using > "option env=" syntax. It is tedious to add a config entry for each > environment given that we need more environments such as 'CC',

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

On Mon, Mar 26, 2018 at 10:29 PM, Masahiro Yamada wrote: > To get an environment value, Kconfig needs to define a symbol using > "option env=" syntax. It is tedious to add a config entry for each > environment given that we need more environments such as 'CC', 'AS', > 'srctree' etc. to evaluate

[PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

To get an environment value, Kconfig needs to define a symbol using "option env=" syntax. It is tedious to add a config entry for each environment given that we need more environments such as 'CC', 'AS', 'srctree' etc. to evaluate the compiler capability in Kconfig. Adding '$' to symbols is

[PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

To get an environment value, Kconfig needs to define a symbol using "option env=" syntax. It is tedious to add a config entry for each environment given that we need more environments such as 'CC', 'AS', 'srctree' etc. to evaluate the compiler capability in Kconfig. Adding '$' to symbols is