Re: [PATCH v2 04/23] ARM: LPC32xx: Add DMA configuration to platform data

2012-07-11 Thread Roland Stigge
On 07/11/2012 03:25 PM, Arnd Bergmann wrote: > On Wednesday 11 July 2012, Roland Stigge wrote: >> OK, thanks! >> >> Is a patch on top of the already provided lpc32xx-next branches the >> preferred form for a fix? On top of which branch do you need it? >> > > Yes, I think in this case, changing it

Re: [PATCH v2 04/23] ARM: LPC32xx: Add DMA configuration to platform data

2012-07-11 Thread Arnd Bergmann
On Wednesday 11 July 2012, Roland Stigge wrote: > OK, thanks! > > Is a patch on top of the already provided lpc32xx-next branches the > preferred form for a fix? On top of which branch do you need it? > Yes, I think in this case, changing it on top of that branch is best. I'm not sure how that

Re: [PATCH v2 04/23] ARM: LPC32xx: Add DMA configuration to platform data

2012-07-11 Thread Roland Stigge
On 07/11/2012 02:33 PM, Arnd Bergmann wrote: > On Wednesday 11 July 2012, Roland Stigge wrote: >> Thanks for the note! Looks like the interface consolidated to replace >> ch->cd->min_signal with sth. like cd->min_signal directly. >> >> Accessing the signal id/number is/was quite convenient because

Re: [PATCH v2 04/23] ARM: LPC32xx: Add DMA configuration to platform data

2012-07-11 Thread Arnd Bergmann
On Wednesday 11 July 2012, Roland Stigge wrote: > Thanks for the note! Looks like the interface consolidated to replace > ch->cd->min_signal with sth. like cd->min_signal directly. > > Accessing the signal id/number is/was quite convenient because as you > can see in the 3 above cases that now get

Re: [PATCH v2 04/23] ARM: LPC32xx: Add DMA configuration to platform data

2012-07-11 Thread Roland Stigge
On 07/10/2012 11:36 PM, Arnd Bergmann wrote: >> +/* NOTE: These will change, according to RMK */ >> +static int pl08x_get_signal(struct pl08x_dma_chan *ch) >> +{ >> +return ch->cd->min_signal; >> +} >> + > > This has changed now, rendering linux-next broken for lpc32xx_defconfig: > > /home/ar

Re: [PATCH v2 04/23] ARM: LPC32xx: Add DMA configuration to platform data

2012-07-10 Thread Arnd Bergmann
On Thursday 14 June 2012, Roland Stigge wrote: > --- linux-2.6.orig/arch/arm/mach-lpc32xx/phy3250.c > +++ linux-2.6/arch/arm/mach-lpc32xx/phy3250.c > @@ -226,7 +226,38 @@ static int __init phy3250_spi_board_regi > } > arch_initcall(phy3250_spi_board_register); > > +static struct pl08x_channel_d